After lots of testing by David3k, he noticed a much lower VPS at very GPU bottlenecked scene with this PR. But the FPS wasn't affected, so did you test FPS or VPS?
I've fixed a race condition in our syncing code. It is possible that the CPU continues too early which leads to fps/vps divergence. Do you notice some strange fps/vps rates in this test cases on master? Through this race condition speeds up dolphin, our CPU emulation will get angry with a broken syncing.
I'm still surprised as nobody was able to confirm this huge slowdown. Did you use some uncommon settings like syncGpu or deterministic dual core?
I've fixed a race condition in our syncing code. It is possible that the CPU continues too early which leads to fps/vps divergence. Do you notice some strange fps/vps rates in this test cases on master? Through this race condition speeds up dolphin, our CPU emulation will get angry with a broken syncing.
I'm still surprised as nobody was able to confirm this huge slowdown. Did you use some uncommon settings like syncGpu or deterministic dual core?