• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › General Discussion v
« Previous 1 ... 126 127 128 129 130 ... 323 Next »

Please bring back "Disable Lightning" option
View New Posts | View Today's Posts

Pages (3): 1 2 3 Next »
Thread Closed 
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Please bring back "Disable Lightning" option
12-18-2012, 07:07 AM
#1
cluthz Offline
Member
***
Posts: 130
Threads: 6
Joined: May 2012
The last few builds does not have "Disable Lightning" option anymore.
I know that in most cases this option is not anything you would use, as it removes most shadows.
However on Mac OSX this is the was to fix the totally broken shadows in many games.

As it stands for now, many games that was actually ok to play before this option was removed is now, well, very much less fun to play.

Here is a pic from Monster Hunter Tri with and without "lightning disabled"
[Image: monsterhuntertri.jpg]

Please bring this option back again
Desktop                                             HTPC:
Gigabyte Z97X-Gaming5- i7-4790k      MSI-B75-E33, i5-2500k
Corsair Vengeance 16GB RAM              Crucial 8GB RAM
Gigabyte GTX780 GHz Edt.                  ASUS GTX960 Strix
Win 10 Pro / OS X 10.10                     Win 10 Pro
Find
12-18-2012, 07:08 AM
#2
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,214
Threads: 50
Joined: Jun 2009
There's no one stopping you from locally reverting the commit that removed the option.
My blog
Me on Twitter
My wishlist on Amazon.de
Find
12-18-2012, 07:19 AM
#3
cluthz Offline
Member
***
Posts: 130
Threads: 6
Joined: May 2012
(12-18-2012, 07:08 AM)neobrain Wrote: There's no one stopping you from locally reverting the commit that removed the option.
I do understand that, and I could build it myself. However this is a huge issue for any mac user (at least with NVIDIA graphics), and not just me.
So unless it's problematic to keep it in I guess that both me and many others would like to have this option.

If it's problematic to keep it, i do understand, but if it was just removed because devs thought it was not used, then I would like to have it put back again Smile
Desktop                                             HTPC:
Gigabyte Z97X-Gaming5- i7-4790k      MSI-B75-E33, i5-2500k
Corsair Vengeance 16GB RAM              Crucial 8GB RAM
Gigabyte GTX780 GHz Edt.                  ASUS GTX960 Strix
Win 10 Pro / OS X 10.10                     Win 10 Pro
Find
12-18-2012, 07:36 AM (This post was last modified: 12-18-2012, 07:38 AM by pauldacheez.)
#4
pauldacheez Offline
Basically Hitler
*******
Posts: 1,532
Threads: 1
Joined: Apr 2012
As much as I like the idea of bringing Disable Lighting/Textures back and putting them both in the Advanced panel...

...how 'bout we just fix the fucking Nvidia bug?
<@skid_au> fishing resort is still broken: http://i.imgur.com/dvPiQKg.png
<@neobrain> dafuq
<+JMC47> no dude, you're just holding the postcard upside down
----------------------------------------
<@Lioncash> pauldachz in charge of shitposting :^)
Website Find
12-18-2012, 07:40 AM
#5
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,214
Threads: 50
Joined: Jun 2009
... which is not even an nvidia bug but a Dolphin one
My blog
Me on Twitter
My wishlist on Amazon.de
Find
12-18-2012, 07:49 AM
#6
delroth Offline
Making the world a better place through reverse engineered DSP firmwares
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,353
Threads: 63
Joined: Aug 2011
might not even be*

The compiled ARB shader does not look like it has any undefined behavior, but it works on Linux and fails on OSX (tried playing the same trace from apitrace on both).
Pierre "delroth" Bourdon - @delroth_ - Blog

<@neobrain> that looks sophisticated enough to not be a totally dumb thing to do
Website Find
12-18-2012, 07:53 AM
#7
cluthz Offline
Member
***
Posts: 130
Threads: 6
Joined: May 2012
Fixing the bug would be awesome, and I think people have asked about this since forever.
However, it's still there, and the disable lightning is somewhat a "fix".

On a side note, I'm pretty inexperienced with git, how to just revert one single commit?
Also any quick way to find you which revision that corresponds to which commit?

Btw this is the commit i guess:
http://code.google.com/p/dolphin-emu/source/detail?r=1dd6b978c1dafccbc8b7db9efb5c15d75596d1c8
Desktop                                             HTPC:
Gigabyte Z97X-Gaming5- i7-4790k      MSI-B75-E33, i5-2500k
Corsair Vengeance 16GB RAM              Crucial 8GB RAM
Gigabyte GTX780 GHz Edt.                  ASUS GTX960 Strix
Win 10 Pro / OS X 10.10                     Win 10 Pro
Find
12-19-2012, 08:11 AM
#8
NaturalViolence Offline
It's not that I hate people, I just hate stupid people
*******
Posts: 9,036
Threads: 24
Joined: Oct 2009
Lightning is produced by the buildup of electric charge in the atmosphere. Unfortunately the dolphin devs have no control over the atmosphere and if they did neobrain would probably remove clouds entirely instead of fixing the charge buildup.

I find it odd that all 4 times you tried to spell lighting it was spelled as lightning.

On a more serious note when was disable lighting removed? I mean the exact revision.
"Normally if given a choice between doing something and nothing, I’d choose to do nothing. But I would do something if it helps someone else do nothing. I’d work all night if it meant nothing got done."  
-Ron Swanson

"I shall be a good politician, even if it kills me. Or if it kills anyone else for that matter. "
-Mark Antony
Website Find
12-19-2012, 08:19 AM (This post was last modified: 12-19-2012, 08:19 AM by neobrain.)
#9
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,214
Threads: 50
Joined: Jun 2009
The option served absolutely no purpose (sorry, working around the osx lighting issue doesn't count). However, lots of noobs where coming to our forums complaining about issues with lighting when "Disable lighting" was used (ofc they didn't notice they enabled that option because they just blindly took over the settings from mamario's idiotic performance guide).

So it's basically no advantages vs that pretty annoying "disadvantage" (if you can call it like that).

EDIT: Meh, misread your question. Learn how to read please, your question has already been answered Tongue
My blog
Me on Twitter
My wishlist on Amazon.de
Find
12-19-2012, 08:24 AM
#10
TheCow
Unregistered
 
Quote: Lightning is produced by the buildup of electric charge in the atmosphere.
Damn, beat me to it!

Quote: On a more serious note when was disable lighting removed? I mean the exact revision.
The one linked in post #7 seems like a good candidate:
Code:
Log message
Remove "Disable Lighting".

I reverted that revision and enabled the option, and it seemed to "work".
« Next Oldest | Next Newest »
Pages (3): 1 2 3 Next »
Thread Closed 


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode