• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 7 8 9 10 11 ... 114 Next »

Performance related analysis
View New Posts | View Today's Posts

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Performance related analysis
03-12-2020, 09:01 PM
#1
necros2k7
Unregistered
 
Externals/gtest/src/gtest.cc:3706] (performance) The conversion from const char* as returned by c_str() to std:Confusedtring creates an unnecessary string copy. Solve that by directly passing the string. [stlcstrParam]


Externals/glslang/glslang/MachineIndependent/propagateNoContraction.cpp:534] (performance) Either inefficient or wrong usage of string::find(). string:Confusedtarts_with() will be faster if string::find's result is compared with 0, because it will not scan the whole string. If your intention is to check that there are no findings in the string, you should compare with std:Confusedtring::npos. [stlIfStrFind]
Externals/glslang/glslang/MachineIndependent/propagateNoContraction.cpp:539] (performance) Either inefficient or wrong usage of string::find(). string:Confusedtarts_with() will be faster if string::find's result is compared with 0, because it will not scan the whole string. If your intention is to check that there are no findings in the string, you should compare with std:Confusedtring::npos. [stlIfStrFind]


Externals/glslang/glslang/MachineIndependent/LiveTraverser.h:122] (performance) Searching before insertion is not necessary. [stlFindInsert]


Externals/glslang/SPIRV/hex_float.h:125] (performance) When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'data_' a value by passing the value to the constructor in the initialization list. [useInitializationList]

Externals/glslang/SPIRV/SpvBuilder.h:514] (performance) Parameter 'newChain' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++. [passedByValue]


Externals/glslang/StandAlone/spirv-remap.cpp:61] (performance) Parameter 'filename' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++. [passedByValue]
Reply
03-12-2020, 09:48 PM
#2
JosJuice Offline
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 8,625
Threads: 7
Joined: Oct 2014
These are all in Externals. We don't make custom patches to third-party code unless there's a good reason (since things can get messy once you try to update to a newer version later), and minor performance optimizations like these are not good enough reasons. Feel free to bring up these problems with the upstream projects if you want to.
Find
Reply
« Next Oldest | Next Newest »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode