Yeah, but it doesn't do the with the PB.StopOnSilence hack and the game loads instantly.
[Patch] zww prologue music fix
|
08-16-2010, 11:16 PM
definitely improves the skipping, now its less like a scratched vinyl record but yes as you've already noted it still pops n crackles....like a vinyl . nice work though. oh also the emu crashes when i try to config the plugin but maybe its because i use an older rev.
08-17-2010, 02:01 AM
ahhaa, yeap, sounds like a vinyl, cuz we need to improve some switching xD. The crash you have maybe is related to the old rev. I think i'll commit this, since that black screen is not related to dsp
08-17-2010, 03:10 AM
(08-16-2010, 12:00 PM)Xtreme2damax Wrote: 1. Disable frame limiter. Its not like you're going anywhere without frame limiter (or do you like to play at 300+ fps?). I noticed the black screen too, but as others said, its never fatal, it only takes a bit more time until the counter reaches zero and enters the end-state. I believe this is due to some other timing issue, not found in that part of the code. I wouldn't re-introduce the StopOnSilence hack, unless it really breaks something (and no, taking a few seconds longer than expected is not seriously broken). 08-17-2010, 03:26 AM
(This post was last modified: 08-17-2010, 03:41 AM by Xtreme2damax.)
Yeah I know, but it's still considered an issue or bug even if it's trivial. I know it isn't a big deal, but it should be fixed sometime later on when it is known what the issue is.
08-17-2010, 05:41 AM
Apart from that, what do you (everyone that tested the change) think of it? Keep the old stuff (jumping around, crackling) or commit the new stuff (mostly fine, rare skipping due to timing, minor crackles in some cases)?
08-17-2010, 06:08 AM
I still notice some issues, a bit of skipping, popping, crackling. I would say it needs a bit more work before it is committed, the current patch of neXus's I am using seems to alleviate most of the problem except for a bit of popping/crackling, but the new patch seems to have a bit more issues.
08-17-2010, 06:24 AM
Hi folks,
first of all: really cool that you tackle this issue! Hmm, either I do something wrong or some settings are not correct. With your patch the intro and prolouge sounds even worse than before (in my opinion it is clearer without the patch... there seems to be a constant noise in the background). Moreover, the timing is not correct. The music starts more than half a minute to late in the prolouge (watch the youtube video to see correct timing). So the bStopOnSilence hack seems to be still necessary... Maybe you can repoduce my observations: Just start a new game, let the intro music play some seconds, enter your name and watch the prolouge. But as I said, keep up the great work greetz, neXus P.S.: I have a 64 Bit machine. Furthermore, I tested it with Audio Throttle turned on and off. P.P.S.: I only tested it and didn't look at the code. 08-17-2010, 07:22 AM
its a hard one. just tried this plugin with r6102 and the trade-off as is works on my system is that the normal plugin plays the sounds a lot clearer but skips wildly and the music gets way ahead of itself. the patched plugin has far superior timing and the music for me comes more or less at the right time with the upbeat part of the score arriving just when the picture of link appears on screen (although not always perfectly), but the crackles and general sound quality is poorer.
for me its like listening to a song on a messed up cd or the same song on an old cassette tape. i'd rather hear it on a poor, fuzzy sounding cassette than on the cd that skips all over since thats no use at all. well i havent tried any other patch so i cant compare but this is a step or two in the right direction, good job for working hard at it and that goes to all the dolphin devs too . |
« Next Oldest | Next Newest »
|
Users browsing this thread: 1 Guest(s)