[PATCH] Super Smash Bros Brawl USA fix

[skid]

I have created a patch to pass the Game ID disc check in the USA version of Super Smash Bros Brawl.

The DSP was overwriting the Game ID when it performed a DMA call to write to ARAM at 0x00000000. This patch performs a sanity check before performing a DMA transfer.

I have also tidied up the Wii disc loading routine in BS2Emu to align it with the memory map in the Wiibrew documentation. This also makes it consistent with how the SSBB code reads the disc id.

This patch fixes issue 303 and its duplicates 417, 519, 964, 25.

Tested on debug and release on x64 with single and dual layer wii games, gc games.

EDIT: Updated the patch file. The first patch broke the sound in Wii Sports.

[KHRZ]

Congratulations, I have PAL though so can't test. But sure many people will ASAP...

[shuffle2]

please put this on the issue tracker with a patch against head instead of here.

great job finding the issue, but I think the way you fix it isn't so good...more of a hack :>

[n3kuh]

How do I use this?

[MarioMadness]

Cool I've been waiting forever for something like this!!

I Hope This gets committed soon So everyone can enjoy Super Smash bros Brawl NTSC!

[Nebetsu]

(12-11-2009, 04:19 AM)n3kuh Wrote: How do I use this?

[James333]

You have to apply the patch in the source code

[skid]

To use the patch, apply it to the source code and compile.

Someone with commit access can add it to the HEAD in svn. I have attached the patch to the issue here:

https://code.google.com/p/dolphin-emu/issues/detail?id=303

[Nebetsu]

Patch works.

Any way I can use my PAL save in NTSC Smash Bros?

[James333]

idk , try changing the save folder from 52534250 to 52534245 and see what happens

MAKE A BACKUP FIRST