[PATCH] DSP-HLE Plugin: Zelda WW Prologue Music

[neXus]

Hi,
the looping problem in Zelda TP (and SMG I think) is more difficult than I thought. That's why I tried to work at another problem. So I created another thread for this patch.

I tried to repair the music in ZWW prologue.
The music is not played accurately with this patch but at least it doesn't jump anymore. Sometimes the music is even played correctly. Cracking is still present . (Another timing problem ?!?)

Hope this patch does not break other games.

Happy testing

P.S.: Someone with emulation knowledge should look at my comments in the code... Maybe they give hints how to solve the clicking noise problem.

---

The updated version contains RetroX' hint (thanks ). No other improvements are included.

[ZEROx]

Thanks, very nice patch all this little cracking much better than OpenAl sound, and it seems music loops with DSound no more, so no more random blackscreen as well

[skid]

The code looks good to me.

[StripTheSoul]

Wind Waker? I played through it, like half a year ago, with Dolphin, and I don't think I remember any music cut-outs or loops or crackles... *shrug*

[crow132]

(05-09-2010, 07:04 PM)StripTheSoul Wrote: Wind Waker? I played through it, like half a year ago, with Dolphin, and I don't think I remember any music cut-outs or loops or crackles... *shrug*

Not during the game, but the intro sounds horrible xD It reminds me of Tales fo symphonia BGM.

Btw, I see you are working on sound so, would be possible to fix the virtual console games? Much of them have no sound. Other are totally broken..

Just take a look: http://www.youtube.com/watch?v=HQURd21jemk

[StripTheSoul]

As far as I remember even the intro music was fine. Maybe it got bad with all those 47xx - 5000 commits, especially the medium rare rearchitecturing of the sound system.

[ZeroRawr]

Hi, I'm fairly new to Dolphin emu and it'd be nice if someone gave instructions on how to apply this patch. Many thank yous in advance.

[RetroX]

- ACC0 -= PB.Unk36[0] << 16;
+ ACC0 -= PB.Unk36[0]; // why << 16 ???

should be "<< 16"

0ae3 5400 subr $ACC0, $AX0.H

look into DspIntArithmetic.cpp for info about "subr"

[MasterKillua]

(05-12-2010, 09:42 AM)ZeroRawr Wrote: Hi, I'm fairly new to Dolphin emu and it'd be nice if someone gave instructions on how to apply this patch. Many thank yous in advance.

http://code.google.com/p/dolphin-emu/wiki/WindowsBuild

Right click>Tortoise SVN>Apply patch

--------------------------------------------------
btw, good job with the patch

[neXus]

Hi again
I've uploaded an updated version of the patch. Unfortunately, it does not fix the problem of cracks...

There seems to be more issues with the ZWW prologue. In direct comparison to the original version on the gamecube, music is missing so I looked at the DSP_UC_Zelda.txt file and found some lines which are not included in the source code (lines 3995 - 4037). Does someone know if they are necessary or why they are not included?
If they are essential for a correct emulation, maybe we could try to find the correct source code together so everyone can make suggestions. I've tried to translate it to source code (in a very rough version) but it didn't work.
So if it is important, I (or someone else) could post a possible solution and all forum readers get the possibility of improving the code of dolphin

(05-09-2010, 11:31 PM)crow132 Wrote: Btw, I see you are working on sound so, would be possible to fix the virtual console games? Much of them have no sound. Other are totally broken..

Sorry, but I don't have virtual console games for Dolphin.