• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Site › Dolphin Patches (Archive) v
« Previous 1 2 3 4 5 ... 7 Next »

[PATCH] DSP-HLE Plugin: Zelda WW Prologue Music
View New Posts | View Today's Posts

Pages (4): 1 2 3 4 Next »
Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
[PATCH] DSP-HLE Plugin: Zelda WW Prologue Music
05-07-2010, 10:51 PM (This post was last modified: 05-16-2010, 07:42 PM by neXus.)
#1
neXus Offline
Junior Member
**
Posts: 21
Threads: 3
Joined: Apr 2010
Music 
Hi,
the looping problem in Zelda TP (and SMG I think) is more difficult than I thought. That's why I tried to work at another problem. So I created another thread for this patch.

I tried to repair the music in ZWW prologue.
The music is not played accurately with this patch but at least it doesn't jump anymore. Sometimes the music is even played correctly. Cracking is still present Undecided . (Another timing problem ?!?)

Hope this patch does not break other games.

Happy testing Smile

P.S.: Someone with emulation knowledge should look at my comments in the code... Maybe they give hints how to solve the clicking noise problem.



The updated version contains RetroX' hint (thanks Smile ). No other improvements are included.


Attached Files
.patch   ZeldaWWPrologueMusicV1.patch (Size: 1.34 KB / Downloads: 703)
.7z   64 Bit Plugin_DSP_HLEVersion2SVN5454.7z (Size: 511.04 KB / Downloads: 1,284)
.7z   32 Bit Plugin_DSP_HLEVersion2SVN5454.7z (Size: 447.18 KB / Downloads: 769)
.patch   ZeldaWWPrologueMusicV2.patch (Size: 1.88 KB / Downloads: 909)
Find
05-08-2010, 05:10 AM
#2
ZEROx Offline
Member
***
Posts: 82
Threads: 1
Joined: Apr 2009
Thanks, very nice patch all this little cracking much better than OpenAl sound, and it seems music loops with DSound no more, so no more random blackscreen as well
Find
05-09-2010, 11:51 AM
#3
skid Offline
skidau / skid_au
**********
Developers (Some Administrators and Super Moderators)
Posts: 2,006
Threads: 8
Joined: Aug 2009
The code looks good to me.
Find
05-09-2010, 07:04 PM
#4
StripTheSoul Offline
YouKittenMe?
*******
Posts: 4,639
Threads: 39
Joined: Oct 2009
Wind Waker? I played through it, like half a year ago, with Dolphin, and I don't think I remember any music cut-outs or loops or crackles... *shrug*
Intel i5-4690k (Devil's Canyon) @ 3.5 GHz (+Scythe Mugen) / Gainward GTX 1070 Phoenix (OC'd) / ASUS Z97 PRO GAMER / 16GB G.Skill DDR3-2400 CL10 TridentX / X-Fi XtremeMusic / Win10 Pro 64bit / Dell S2716DG Monitor / 3x original WiiMote+MotionPlus+Nunchuk
Find
05-09-2010, 11:31 PM (This post was last modified: 05-09-2010, 11:47 PM by crow132.)
#5
crow132 Offline
Member
***
Posts: 102
Threads: 16
Joined: Apr 2009
(05-09-2010, 07:04 PM)StripTheSoul Wrote: Wind Waker? I played through it, like half a year ago, with Dolphin, and I don't think I remember any music cut-outs or loops or crackles... *shrug*

Not during the game, but the intro sounds horrible xD It reminds me of Tales fo symphonia BGM.

Btw, I see you are working on sound so, would be possible to fix the virtual console games? Much of them have no sound. Other are totally broken..

Just take a look: http://www.youtube.com/watch?v=HQURd21jemk
[Image: firmamasseffect.jpg]
[Image: 1169783.png]
Find
05-10-2010, 06:02 AM
#6
StripTheSoul Offline
YouKittenMe?
*******
Posts: 4,639
Threads: 39
Joined: Oct 2009
As far as I remember even the intro music was fine. Maybe it got bad with all those 47xx - 5000 commits, especially the medium rare rearchitecturing of the sound system.
Intel i5-4690k (Devil's Canyon) @ 3.5 GHz (+Scythe Mugen) / Gainward GTX 1070 Phoenix (OC'd) / ASUS Z97 PRO GAMER / 16GB G.Skill DDR3-2400 CL10 TridentX / X-Fi XtremeMusic / Win10 Pro 64bit / Dell S2716DG Monitor / 3x original WiiMote+MotionPlus+Nunchuk
Find
05-12-2010, 09:42 AM
#7
ZeroRawr
Unregistered
 
Hi, I'm fairly new to Dolphin emu and it'd be nice if someone gave instructions on how to apply this patch. Many thank yous in advance.
05-12-2010, 10:14 AM (This post was last modified: 05-12-2010, 10:15 AM by RetroX.)
#8
RetroX Offline
Junior Member
**
Posts: 46
Threads: 2
Joined: Jun 2009
- ACC0 -= PB.Unk36[0] << 16;
+ ACC0 -= PB.Unk36[0]; // why << 16 ???

should be "<< 16"

0ae3 5400 subr $ACC0, $AX0.H

look into DspIntArithmetic.cpp for info about "subr"
Find
05-13-2010, 12:04 PM
#9
MasterKillua Offline
What's the Matter, Scared?
***
Posts: 106
Threads: 25
Joined: Mar 2009
(05-12-2010, 09:42 AM)ZeroRawr Wrote: Hi, I'm fairly new to Dolphin emu and it'd be nice if someone gave instructions on how to apply this patch. Many thank yous in advance.

http://code.google.com/p/dolphin-emu/wiki/WindowsBuild

Right click>Tortoise SVN>Apply patch

--------------------------------------------------
btw, good job with the patch Smile
[Image: masterfirma.png]
Find
05-16-2010, 07:53 PM
#10
neXus Offline
Junior Member
**
Posts: 21
Threads: 3
Joined: Apr 2010
Hi again Smile
I've uploaded an updated version of the patch. Unfortunately, it does not fix the problem of cracks...

There seems to be more issues with the ZWW prologue. In direct comparison to the original version on the gamecube, music is missing so I looked at the DSP_UC_Zelda.txt file and found some lines which are not included in the source code (lines 3995 - 4037). Does someone know if they are necessary or why they are not included?
If they are essential for a correct emulation, maybe we could try to find the correct source code together so everyone can make suggestions. I've tried to translate it to source code (in a very rough version) but it didn't work.
So if it is important, I (or someone else) could post a possible solution and all forum readers get the possibility of improving the code of dolphin Smile


(05-09-2010, 11:31 PM)crow132 Wrote: Btw, I see you are working on sound so, would be possible to fix the virtual console games? Much of them have no sound. Other are totally broken..

Sorry, but I don't have virtual console games for Dolphin.
Find
« Next Oldest | Next Newest »
Pages (4): 1 2 3 4 Next »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode