[Patch] Auto Frameskip - update page 3

Unknownforce · 08-13-2009, 06:18 AM **#71**

(08-13-2009, 05:57 AM)Iulius Wrote: i can confirm it too, look at the commit comments

i also mentioned this before in this thread somewhere.

it cant be fixed without breaking auto mode in all other games or game specific hack for auto mode (lol, what a strange idea)

well, that means it cannot be fixed at all.

in any case : auto mode is still better then full frameskip 9 in sunshine + you dont have to use 9 + sunshine runs great without frameskip or 1 maximum

thats why i dont really cared about it

Quote:It sounds like the actual frameskipping is not getting fully circumvented every time.

not my fault when games render unsteady frames.

its impossible to know if a frame was late because of a random effect or if it was late because the game runs slow.

as the second is much more often and also the reason why we want frameskip, i made it always think the game runs slow when a frame comes late.

This is why there needs to be an Auto Option instead of integrating it into the already available options. Auto should scale up to 9 or more if necessary without the user having to set that as the maximum.

True auto frameskip would be dolphin ONLY dropping frames to ensure the full speed of the core. Since the full speed of the core could be reached without frame skip and yet frames are STILL being dropped... then it doesn't work as it should and needs more work. I'm not dismissing your work, as it kind of works and it's definitely a big step in the right direction, but I wouldn't call it final since it's not complete.

And I'm not saying its your fault... you can only do the best you can with what you got. But it's the truth, whether you can fix it or not.

While it might be impossible to tell the difference between the two, the point is you shouldn't have to with auto frameskip, it shouldn't be based on whether the game is slow or a random effect, it should simply be based off of current CORE FPS count compared to the Target CORE FPS count. And let it do the scaling on it's own, not having to set a maximum on it.

While I don't know much about the programming aspect of it, it sounds like you're just tapping into the already available Frameskip option and just letting it handle the skipping as needed when it determines the game is running slow... auto mode should be a separate entity that handles the frame skipping itself, hence the reason for the "Auto" selection instead of the numbered selections that are available now.

Again, I'm only offering my help, not shooting down your work at all, it's great and I think you should continue working on it. Collaboration is what these projects are all about. Smile

**Xtreme2damax** · 08-13-2009, 07:12 AM **#72**

Does the auto frame skip work with the frame limiter set to auto?

Unknownforce · 08-13-2009, 07:26 AM **#73**

(08-13-2009, 07:12 AM)Xtreme2damax Wrote: Does the auto frame skip work with the frame limiter set to auto?

Yes, but auto frame limiter is buggy from what I hear, best to just set it to the actual game limit, like 60 fps for most NTSC games 50 for most PAL and 30 for things like the Zelda's, and some others.

Iulius · (This post was last modified: 08-13-2009, 04:47 PM by Iulius.)

guys, im very sorry.

the newest version called "final" has some bug.

it uses always 1 more frameskip that is needed.

the reason is this line in core.cpp :

Quote:if (Timer.GetTimeDifference() < wait_frametime * (frames + skipped - 1))

the "-1" is WRONG and was here for testing purpose.

Please daco or someone with access to svn fix this.

just edit the line to

if (Timer.GetTimeDifference() < wait_frametime * (frames + skipped))

thank you !

Emulatong · 08-13-2009, 06:19 PM **#75**

how do I use this Auto Frameskip?

I have build 3975

satan666 · 08-13-2009, 08:40 PM **#76**

It always turn on. You didn't set your config.

Emulatong · 08-13-2009, 09:24 PM **#77**

(08-13-2009, 08:40 PM)satan666 Wrote: It always turn on. You didn't set your config.

so how to set my config that will be effective?

Iulius · 08-13-2009, 10:35 PM **#78**

frameskip to desired maximum value and framelimit to games frames limit.

thats all.

keep in mind that it got a bug at the moment that will be fixed whenever Dacos awakening happens Tongue

**DacoTaco** · 08-14-2009, 01:23 AM **#79**

(08-13-2009, 10:35 PM)Iulius Wrote: frameskip to desired maximum value and framelimit to games frames limit.

thats all.

keep in mind that it got a bug at the moment that will be fixed whenever Dacos awakening happens

or nakee feels like loving us Tongue

BlackLionPT · 08-15-2009, 05:26 AM **#80**

Just a question:
Isn't possible to make dolphin only reproduce some frames?
Instead of skiping, make the game runing in a total of 30 frames (for example), like in some games, you can select the frames (Sonic Heroes is one of those).
That would make the game run faster, and no computer power would be wasted.