• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Site › Dolphin Patches (Archive) v
« Previous 1 ... 3 4 5 6 7 Next »

[PATCH] A few code condensations
View New Posts | View Today's Posts

Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
[PATCH] A few code condensations
08-08-2010, 06:44 AM (This post was last modified: 08-08-2010, 10:38 AM by avindra.)
#1
avindra Offline
Junior Member
**
Posts: 47
Threads: 10
Joined: Jun 2010
-Change if... else to switch logic in a few places.
-Condense logic sections for shorter and more readable code
-Other similar logic changes.
-Reword funny sounding panic alert in the cheats window.

EDIT: More condensations included.
EDIT2: A few more.
EDIT3: Update patch for latest revision.


Attached Files
.patch   dolphinCodeCondense.patch (Size: 23.21 KB / Downloads: 194)
[Image: stats.png]
Find
08-08-2010, 02:44 PM
#2
skid Offline
skidau / skid_au
**********
Developers (Some Administrators and Super Moderators)
Posts: 2,004
Threads: 8
Joined: Aug 2009
The code looks ok - just formatting changes. You may as well ask ector access, see what he says.
Find
08-08-2010, 09:13 PM
#3
Jack Frost Offline
aka. BhaaL
**********
Developers (Some Administrators and Super Moderators)
Posts: 498
Threads: 3
Joined: Oct 2009
I'd be careful with those break; statements in the same line. We had this at least twice already where a line was commented out - along with the break, causing odd things.
I'd put them in the next line, if you ask me.
Find
09-15-2010, 03:28 AM
#4
maconfaris
Unregistered
 
I would be careful of those break; statements on the same line. We have already had at least two times when the line was commented on - along with the rest because strange things. I had put on the next line, if you ask me.
09-16-2010, 02:23 PM
#5
NaturalViolence Offline
It's not that I hate people, I just hate stupid people
*******
Posts: 9,009
Threads: 24
Joined: Oct 2009
^obvious bot alert

Look at his posts and also look at the sig.
"Normally if given a choice between doing something and nothing, I’d choose to do nothing. But I would do something if it helps someone else do nothing. I’d work all night if it meant nothing got done."  
-Ron Swanson

"I shall be a good politician, even if it kills me. Or if it kills anyone else for that matter. "
-Mark Antony
Website Find
09-16-2010, 04:41 PM
#6
skid Offline
skidau / skid_au
**********
Developers (Some Administrators and Super Moderators)
Posts: 2,004
Threads: 8
Joined: Aug 2009
maconfaris' comment fits the code in the patch. I've removed the link in the sig. If the link is put back, maconfaris will be banned.
Find
« Next Oldest | Next Newest »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode