_OSAtomicIncrement32Barrier missing on OSX 10.9.5

[JosJuice]

Can anyone confirm that the automatic build of the pull request makes Dolphin work on 10.9? http://dl.dolphin-emu.org/prs/pr-4230-dolphin-latest.dmg

[mchtly@gmail.com]

(09-21-2016, 03:05 AM)JosJuice Wrote: Can anyone confirm that the automatic build of the pull request makes Dolphin work on 10.9? http://dl.dolphin-emu.org/prs/pr-4230-dolphin-latest.dmg

That build has the same issues as current master builds. Looks like the buildbot is using a cached CMake config that already has LIBUSB_FOUND set to TRUE. Is there some way to tell it to reconfigure from scratch?

EDIT: Tweaked the PR so when the next build happens it should ignore the cache and build the vendored libusb.

EDIT: Latest automatic build of the PR no longer references OSAtomicIncrement32Barrier, does anyone want to check if it works on 10.9? http://dl.dolphin-emu.org/prs/pr-4230-dolphin-latest.dmg

(09-20-2016, 10:30 PM)Mike4Real Wrote: Excellent job dude! You clearly understood everything that was going on here. I don't understand it all, but from what I gather some of the assumptions I was making were correct. Nicely done fixing it, I wouldn't have been able to do that. I wonder if your fix by building the library specifically for Dolphin will also help prevent future issues that could come up.

Thanks! Yeah, your previous post about a local build picking up your local libusb reminded me that that's actually what happens on the buildbots.

[Mike4Real]

(09-21-2016, 05:12 AM)mchtly@gmail.com Wrote: EDIT: Latest automatic build of the PR no longer references OSAtomicIncrement32Barrier, does anyone want to check if it works on 10.9? http://dl.dolphin-emu.org/prs/pr-4230-dolphin-latest.dmg

I downloaded pr-4230, so I don't get the error that we have been talking about here. Dolphin opens just fine. However, it looks like there might be some other problem that's happening.

I opened pr-4230 just fine, I tried to run Super Smash Bros. Melee, and for some reason it starts very slowly. I only get 1 FPS and it opens to the "There is no Memory Card in slot A." screen. This shouldn't be happening because I have the Gecko Code for Netplay settings enabled which should boot me to the character select screen. I can't get past this screen and it just sits at 1 or 2 FPS. Dolphin 5.0-321 still works fine. I am not sure if it is the recent changes we made to fix the bug we're talking about here is causing this, or some other change between 5.0-321 and 5.0-649.

[JosJuice]

(09-23-2016, 09:48 AM)Mike4Real Wrote: I opened pr-4230 just fine, I tried to run Super Smash Bros. Melee, and for some reason it starts very slowly. I only get 1 FPS and it opens to the "There is no Memory Card in slot A." screen. This shouldn't be happening because I have the Gecko Code for Netplay settings enabled which should boot me to the character select screen. I can't get past this screen and it just sits at 1 or 2 FPS. Dolphin 5.0-321 still works fine. I am not sure if it is the recent changes we made to fix the bug we're talking about here is causing this, or some other change between 5.0-321 and 5.0-649.

It's an unrelated known bug from 5.0-619. Basically, using any Gecko codes leads to major slowdown and other problems.

[Mike4Real]

(09-23-2016, 04:23 PM)JosJuice Wrote: It's an unrelated known bug from 5.0-619. Basically, using any Gecko codes leads to major slowdown and other problems.

Okay yea that was the problem, thank you. So I turned of Gecko codes and Dolphin 5.0 pr-4230-latest ran fine for me. I did not have to move my local version of libusb into the Dolphin application's contents. So, I think that means mchtly's pull request will fix the compatibility issues that were happening on 10.9

[mchtly@gmail.com]

(09-24-2016, 09:47 PM)Mike4Real Wrote: Okay yea that was the problem, thank you. So I turned of Gecko codes and Dolphin 5.0 pr-4230-latest ran fine for me. I did not have to move my local version of libusb into the Dolphin application's contents. So, I think that means mchtly's pull request will fix the compatibility issues that were happening on 10.9

Awesome! Great to hear that it fixed your problem.