no graphics in current master

[triad]

Well, this is odd, and I can only imagine there is system testing lacking that no one noticed this... current master (bc1d9056cc38) has... no render area. Not a big black nothing where GL rendering is supposed to be happening, but no render area at all. There is a big, empty, window-background-colored expanse where the render area is supposed to be.

Anyone know what happened?

(I'm trying to bisect, but having trouble because there's a while where rendering is more normally broken, i.e. the render area exists but doesn't render anything, giving a big black nothing instead. I believe 842f888 at least rendered... much, much worse generally than 3.5, but at least basic stuff worked and well enough to play (some) games.)

[DJBarry004]

Screenshots of settings? Games?

[JMC47]

Use render to main window, something is broken. Please be patient while it is fixed.

[triad]

dc2bc621a4ab appears to have broken rendering; the previous commit works (at least opening screens render; I didn't test exhaustively, but something clearly went wrong there).

9818bd3edfb9 is similarly working. There is no render area at all at 7b6b9b09451b. (@DJBarry004, this affects every game. Something is busted in how dolphin sets up its GL view; it's either failing to create it entirely, or not correctly assigning it to the window, or even more stupid there's another window hiding it. At least, I'd lay money the problem is one of those...)

Bonus points; the first parent of that merge also has sound and at least a big empty black expanse (and 9818bd3edfb9 is the second parent). Something in the merge itself is where things went sideways. I suspect the change made in 9818bd3edfb9 doesn't work correctly in light of something else that changed in the mean time before the merge happened. (Certainly the nature of the change there matches my above assertion as to the nature of the problem.)

---

Didn't check 'render to main window', but reverting dc2bc621a4ab fixes it.

---

'Render to main window' does at least work... I think I'll stick with locally reverting dc2bc621a4ab, though, until it's fixed.

[triad]

...and also if the window is resized, apparently. See also discussion at https://github.com/dolphin-emu/dolphin/commit/dc2bc621a4ab405 .