New change "VideoCommon: Skip vsync if configured emulation speed is not 100%" issue

[psycode]

I play with my two friends Mario Kart Wii on weekends for years.

As you know the game limits FPS to max 30 when you start race for 3-4 players. We can't accept that awful low framerate so for all that years I'm using my way to deal with it.
-Speed Limit increased to 130%. It gives me nice boost: 39/40 FPS during 3-4 players gameplay. (I do not touch CPU clock - it stays at 100%)
-To correct sound pitch to normal I use XAudio2 with Audio Stretching.
-To correct sound jitter/shutter I use 60-80ms Buffer size/latency.
This config gaves me dynamic and smooth gameplay for years.

BUT Starting from fresh version 5.0-8729, you've made change: "VideoCommon: Skip vsync if configured emulation speed is not 100%"

And now I have Screen tearing!
During course presentation demo before each race FPS jumps from 50 to 80 with screen tearing.
And during gameplay FPS jumps from 38-41 with screen tearing as well.
When player drive cart and then turns - the world is not turning smooth.
I have V-sync still set to on, but it doesn't make any difference.

I've read PR #7398 so I understand theory and reasons, but leave theory and look at practice: my gameplay is ruined right now.

Maybe the best compromise will be a script: to force vsync checkbox to off if user touch and increase speed above 100% (this will make exactly the same change as you did and as they want to have)
BUT if that user go then to settings and set that v-sync checkbox to on again then it could brings back v-sync functionality as it was in older version.

thank you.

specs:
i7 4GHz, GTX980, 8RAM, W10 64, Dolphin: D3D11, V-sync on, IR:Auto, 1920x1080.

[JMC47]

There's a 60 FPS hack for MKWii 3/4 player? Use that if you want a high framerate in multiplayer.

[mbc07]

You know you can still force V-Sync through the GPU Control Panel, right?

[psycode]

(09-19-2018, 09:01 AM)JMC47 Wrote: There's a 60 FPS hack for MKWii 3/4 player?  Use that if you want a high framerate in multiplayer.

Oh I didn't know about that! I wish to hear about that earlier. Now is useless for us because of increased speed limit to 130% - we got used to faster animation/game speed for years. So if I come back to 100% speed to fix screen tearing and use your code to fix 60 FPS, then I will be complain about slower gameplay

P.S.
IN FACT i've tried to add that Gecko Code:
$60FPS in Multiplayer [Nick Reynolds]
004250D4 00000001
0029FD69 00000000
and then I set it to on in game properties, but it doesn't work at all. I still have 30FPS at 100% speed and 40FPS at 130%. Other Gecko codes working good.

[psycode]

(09-19-2018, 03:53 PM)mbc07 Wrote: You know you can still force V-Sync through the GPU Control Panel, right?

Thanks! I forgot about it. It fixed my issue with screen tearing!


BUT anyway I'm still asking developer to bring back v-sync when speed limit is more that 100%. Techjar on this thread PR #7398 said that It doesn't make much sense to use v-sync, BUT my case shows that there is a sense/ good reason. 

[mbc07]

Given that it causes issues with the new Netplay "Host Input Authority" mode, it's unlikely this change will be reverted. People who still need it can force V-Sync in the GPU Control Panel...

[psycode]

(09-20-2018, 04:17 AM)mbc07 Wrote: Given that it causes issues with the new Netplay "Host Input Authority" mode, it's unlikely this change will be reverted. People who still need it can force V-Sync in the GPU Control Panel...

One thing i cannot understand. is it realy hard to implement two scenarios? Let the checkbox/switch "v-sync on/off" in dolphin's graphics settings determines that.

if user has v-sync set to on, and then change speed above 100% then force v-sync to off automatically
this will give you what you want to.

but if user then set v-sync checkbox to on again (for own resposibility)- then bring back v-sync as it was in eairlier versions of dolphin.
Is it realy hard to do it?

because now it looks confusing - I have v-sync checkbox set to on but dolphin skip it. 

[Helios]

It's not hard, but UX is an important thing to consider and as much as users would like to believe "more options = better", that really isn't the case.

I believe here we should really be more clear to the user what's going on, but I think that can be done in an OSD message on boot or something.

[psycode]

good point.

btw. What am i doing wrong with that 60FPS 3/4 Players hack in Mario Kart Wii?
Ohter Gecko codes working good, but that one (look few post above) doesn't work.

Is it dolphin's new versions fault or mine?

[Helios]

Cheats in general are known to be pretty wonky right now and cause stuttering.