I asked on IRC, but realized that I need to get some sleep before anyone has a chance to answer, so I'm posting it here instead. Apologies in advance if it got answered there, too.
There are two instances in the DSPJitRegCache.cpp file of a call to movToHostReg() with only 2 parameters, where the second parameter is expected by the function to be a 'bool load' parameter. The calls to the function, however, pass a X64Reg instead. Is this intentional? or was this an oversight and the calls were meant to also have the bool at the end, making it a call to the 3 parameter overload?
The patch is assuming the latter, and is provided to illustrate the context of the question.
There are two instances in the DSPJitRegCache.cpp file of a call to movToHostReg() with only 2 parameters, where the second parameter is expected by the function to be a 'bool load' parameter. The calls to the function, however, pass a X64Reg instead. Is this intentional? or was this an oversight and the calls were meant to also have the bool at the end, making it a call to the 3 parameter overload?
The patch is assuming the latter, and is provided to illustrate the context of the question.