More DTK Audio Fixes

[JMC47]

As many people could tell, there were a few regressions upon the last DTK audio merge. What's being checked out and tested this time is mostly looping within streaming audio. This includes regressions in the Tony Hawk series, Pacman Fever, Crazy Taxi and likely other titles. While I have tested them, frankly, last time I missed a bunch of stuff and know that other experienced testers on the forums caught it way earlier than I did.

The work on this Pull Request was done by booto, and the code can be found here: https://github.com/dolphin-emu/dolphin/pull/664

Issues to test:

Audio Looping in Streaming Audio titles (For information on streaming audio titles: http://www.gc-forever.com/wiki/index.php?title=Audio_Streaming
Possible regressions in titles since the previous DTK merges.
Any kind of issues with streaming audio.

Builds:

Windows: https://dl.dolphin-emu.org/prs/pr-664-dolphin-latest-x64.7z
Mac: https://dl.dolphin-emu.org/prs/pr-664-dolphin-latest.dmg

If you're really feeling adventurous, you could also try to find a feature that hasn't been tested yet. We're currently looking for this to show up in the debug logs: "Change AIINTVLD to (some kind of value goes here)" We were unable to find a game that used this feature in first go around. This is a debug log, so you have to use a debug build, enable debug logs in log configuration. Make sure AudioInt is checked in log configuration as well, and view the log. Then see if the message "Change AIINTVLD to" anything shows up.

Windows Debug: https://dl.dolphin-emu.org/prs/pr-664-dolphin-latest-dbg-x64.7z

[purpasmart96]

Don't forget the messed up audio syncing in project m

[JMC47]

Is it still messed up in the PR? If so, let us know at least.

[purpasmart96]

Yep, both Audio and Auto don't work work, before the DTK rewrite If I set the fps to "audio" it be set at 66fps and variable in the project m loader, it's 33-5 fps in the project m loader when it should be in the mid forties. basically everything that the DTK rewrite fixed broke stuff that was fine.

[JMC47]

Umm, forcing it to run at 66 vps isn't "fine" you're completely wrong on that. Just because it changed the behavior, doesn't mean it broke it. It was obviously broken to begin with. This sounds similar to the Harvest Moon AudioInterface problem, which has been in Dolphin since... pretty much forever. It's just that DTK audio was so hopefully broken that you could make the emulator run the wrong framerate in order to "hide" the issue.

[purpasmart96]

(07-25-2014, 12:40 PM)JMC47 Wrote: Umm, forcing it to run at 66 vps isn't "fine" you're completely wrong on that. Just because it changed the behavior, doesn't mean it broke it. It was obviously broken to begin with. This sounds similar to the Harvest Moon AudioInterface problem, which has been in Dolphin since... pretty much forever. It's just that DTK audio was so hopefully broken that you could make the emulator run the wrong framerate in order to "hide" the issue.

I'l upload the a video showing the issues with project M that will help with some of the confusion. I'd rather it output the wrong framerate then having the audio all messed up.

[JMC47]

It's not confusing, if you're forcing the game to run at the wrong speed (66 vps) to hide a bug, that doesn't mean anything. Sure, DTK audio fixes can make that work-around no longer work, but the goal is to fix the problem that's causing audio to play at the wrong rate in the first place.

My issue with this is that it's likely unrelated to the DTK rewrite, and that another but in the Audio Interface is to blame.

[phire]

The original reason for audio sync has been invalid for a while, we just never got around to removing it.

As it's now broken, it is scheduled to be removed from master in the next few days. Any games which only work with Audio sync should have bug reports filed.