Making the fastest Dolphin version ever

[Rare White Ape]

(09-09-2016, 12:24 PM)Probwontusethisaccountagain Wrote: but it's a dolphin, shouldn't it already be cool?

Nah, they're endotherms.

[dephined]

Every time I downloaded/tried a new Dolphin dev build, I compared it to the previous, so I know perfectly what I'm saying: on my system those PRs slowed the code.
Of course in the meantime others PRs optimized Dolphin, but without the ones that I mentioned it could be much faster.

P.S. ask Skidau if the hotkey PR didn't slowdown Dolphin...he had to make another PR to fix the "callings" of the code (because they were too much), but even with the fix the performance stayed slightly below as it was before...

[KHg8m3r]

You sure it wasn't the fact that it had to generate the shader cache from scratch again because it was a new build of Dolphin?

[Helios]

I love this thread so much

[JMC47]

Okay, let me be more serious. Hotkey changes can cause slowdowns in certain situations; but, you just saying "it's slower" doesn't actually help us. We have people who can monitor performance in Dolphin, see where slowdowns are coming from, "this piece of the code is slower" for instance.

Simply reverting certain changes here and there isn't easy. You have to remember that new changes are built off of old changes. Eventually you're going to be reverting enough of the code that if you think an older version will be faster, just use that version.

Sorry if I was a little demeaning, but I really thought it was a joke at first.

[mimimi]

If you actually see a drop in performance, you could give out more details per pr, what got slower by how much. Also with different settings, single/dual core, 1xIR/3xIR/6xIR and so on. Then, maybe, somebody will look at it.

You won't be getting a build with those prs removed. But if one of them reduced the speed by a lot, somebody might try to fix it, or speed up.