Making the fastest Dolphin version ever

[dephined]

Don't know if this is the right place to post it, anyway I've tracked down the main PRs responsible of slowing down Dolphin, so I'm asking if there is someone that could build an actual/latest Dolphin master removing those PRs (it could even be an interesting experiment to create the fastest Dolphin version ever :-))...
The "slow" PRs are:

PR1623 (introduced with 4.0-4559) https://github.com/dolphin-emu/dolphin/pull/1623

PR1949 (introduced with 4.0-5402) https://github.com/dolphin-emu/dolphin/pull/1949

PR1987 (introduced with 4.0-5441) https://github.com/dolphin-emu/dolphin/pull/1987

PR4095 (introduced with 5.0-379) https://github.com/dolphin-emu/dolphin/pull/4095

I think that a build of the latest Dolphin dev version without those four PRs Dolphin could be 20-25% faster...
Thanks

[MayImilae]

That's not really how it works...

https://dolphin-emu.org/blog/2016/06/24/dolphin-50-release/#better-and-faster-cpu-emulation

[leolam]

lol what, did you just see the comments from that one user saying it caused a slowdown (without any proof backing that claim) and made a list without actually checking if it makes sense?

And even in the cases where some of the changes really make Dolphin slightly slower, it's worth the increase in accuracy.

[Admentus]

That is weird, because I am pretty sure Dolphin 5.0 is faster any ever before. Yeah, some fixes might have slowed down Dolphin a bit for more accuracy. But 30%? That sounds way too much. Then again, the JIT64 improvements were massive boost for performance. As well the improved HLE audio and EFB Copies to Texture Only.

[Helios]

A+

Go for it

[retroben]

I would say try again with more research and testing on each PR build that possibly causes slower speeds than each's equivalent master version until deducing every single fps difference to a precise set of results.
Its a lot more work but would reap more rewarding results if done with enough dedication and patience.

[JMC47]

lol. Once I clicked the link and saw the hotkey one I realized this doesn't belong in the dev section. Maybe random?

[MayImilae]

Oh, whoops, I don't pay enough attention to the sections.

*waves her magic moderator wand*

Moved to Dolphin General Discussion!

[Helios]

(09-09-2016, 10:01 AM)JMC47 Wrote: lol.  Once I clicked the link and saw the hotkey one I realized this doesn't belong in the dev section.  Maybe random?

What are you talking about

Removing hotkey functionality will speed Dolphin up significantly.

By reducing what hotkeys can do, you make the keys less hot, you cool down Dolphin, so it goes faster

[Probwontusethisaccountagain]

(09-09-2016, 11:50 AM)Helios Wrote: What are you talking about

Removing hotkey functionality will speed Dolphin up significantly.

By reducing what hotkeys can do, you make the keys less hot, you cool down Dolphin, so it goes faster

but it's a dolphin, shouldn't it already be cool?