Longlife ot 2059 ;_; its finally live

[Link_to_the_past]

(02-21-2015, 09:10 AM)DaRkL3AD3R Wrote: Yep, re-adding it brought the performance back in line to 5244. So the real question is, does this speedhack break anything? And if not then why remove it? I don't know if there's and discussion on it anywhere. And if there are no known issues, seems rather silly to remove it as it gives a pretty measurable boost to performance. For me it might not matter but for users who don't have as high end a machine as mine it could make a difference between playable and not.

You never know if something will be broken with speedhacks. I removed it from default, it can be set in the wiki for anyone interested to do it at their own risk. Metroid Prime isn't a very demanding game though even without the speedhack, chances are that those having trouble with it now will still have trouble in other dolphin games.

[Nintonito]

(02-21-2015, 09:10 AM)DaRkL3AD3R Wrote: Yep, re-adding it brought the performance back in line to 5244. So the real question is, does this speedhack break anything? And if not then why remove it? I don't know if there's and discussion on it anywhere. And if there are no known issues, seems rather silly to remove it as it gives a pretty measurable boost to performance. For me it might not matter but for users who don't have as high end a machine as mine it could make a difference between playable and not.

It probably doesn't break anything because the JIT was brought up to a state that normal emulation was possible,  but that doesn't mean thy want to keep it.  Cleaning up hacks is quite important for future development.  You can't rely on hacks forever,  no matter how convenient they are.  

[JMC47]

Link_To_The_Past: I would appreciate if it was added to the wiki so that people could at least know about it. That's assuming it's tested a bit more and no one finds a reason for it.

I asked on the IRC what the code is; it's idleskipping. Dolphin's idleskipping doesn't detect whatever Metroid Prime 1/2's idleloop is, this speedhack is basically a replacement for that until Dolphin's idleloop detection is better.

[DaRkL3AD3R]

Well then, safe to keep for now. Definitely will be using it until it's not necessary.

[DaRkL3AD3R]

Sorry for bumping this but the dialog in this topic is extremely relevant. I believe the speedhack we discussed earlier in here for Metroid Prime has been broken when changes were made recently. I'm seeing the horrible performance degradation again and I am all but certain it is due to the changing of the name for IdleSkipping, and the speedhack not agreeing with it. I have the original code enabled in my gameconfig.ini and yet it seems it isn't being enabled.

Any suggestions? I really need that speedhack back, because it is the difference between 35 and 80 fps in the map menu for me.

[NKF98]

no need to apologize for bumping so long as the thread has been active in the last 6 months.

[Link_to_the_past]

(06-11-2015, 07:51 AM)DaRkL3AD3R Wrote: Sorry for bumping this but the dialog in this topic is extremely relevant. I believe the speedhack we discussed earlier in here for Metroid Prime has been broken when changes were made recently. I'm seeing the horrible performance degradation again and I am all but certain it is due to the changing of the name for IdleSkipping, and the speedhack not agreeing with it. I have the original code enabled in my gameconfig.ini and yet it seems it isn't being enabled.

Any suggestions? I really need that speedhack back, because it is the difference between 35 and 80 fps in the map menu for me.

Since it was about idleskipping could you try this instead of the hack and see if it works?
[Core]
SyncOnSkipIdle = False

[DaRkL3AD3R]

Nope no good. Still getting much worse performance than I was before with the speedhack.

Just as an update though, the speedhack does work again. I guess something was reverted somewhere.

[JMC47]

The problem is that we don't detect the idleskipping in Metroid Prime 1/3 with our idleskipping detection; the speedhack is some kind of manual way of doing it, I guess.