JIT ARM 64 - Resident Evil Remake fix (with pr build inside, thanks degasus and devs)

[Servlet]

I'm following degasus explanation on how to debug android app.
My testing game is Resident Evil Remake.

Problem : missing character.

Then I start disabling group in ConfigManager.cpp
bJITPairedOff = true;

This group will fix the character missing. Now I can see character, but frame rate down from 20-25 to 15-20.

Testing phone : Xiaomi Redmi Pro

I will continue to check deeper in the group bJITPairedOff, any pointer on where is it or any help in general is always much appreciated. I can build debug apk if anyone want to play resident evil remake.

Thanks degasus, at least now I can see my character hehe

Edit :
I read JitArm64_Paired.cpp, no clue of what this function do, can I do fall back in this individual function to see which function or functions that cause it ?

[Servlet]

Putting fall back to this function show my character, and no speed down (with fallback or without fallback speed mostly the same).
void JitArm64::ps_res(UGeckoInstruction inst)

JitArm64_Paired.cpp line 155

This is the limit of my knowledge, I have no clue how to fix this function.

So now at least I have dolphin that can play resident evil remake on my phone.
Thanks degasus, I will upload the apk later, but this is from SVN checkout at 5th May 2017.

[Servlet]

Apk uploaded
http://www.droidbin.com/p1bf69uj3a174prhi1p2reroi483

Maybe also work with resident evil 0, I'm not sure, currently playing the resident evil remake, and this game is way harder than the resident evil 1 on ps1 ......

EDIT : [color=#ff3333]Please use pr / master build that include the function fix.[/color] Since its should be better overall.
PR Build : http://dl.dolphin-emu.org/prs/pr-5363-dolphin-latest.apk

[nonexist]

thank you

keep update please

[Servlet]

I'm not a developer, I just debug the jitarm64 based on degasus instruction, regarding on how to fix jit, I have no idea, my knowledge is not that good in this matter.

[nonexist]

(05-03-2017, 02:55 PM)Servlet Wrote: I'm not a developer, I just debug the jitarm64 based on degasus instruction, regarding on how to fix jit, I have no idea, my knowledge is not that good in this matter.

installed fine in my phone

[nonexist]

(05-03-2017, 02:55 PM)Servlet Wrote: I'm not a developer, I just debug the jitarm64 based on degasus instruction, regarding on how to fix jit, I have no idea, my knowledge is not that good in this matter.

hope can play to resident evil 0 wii and resident evil code veronica

RE games are my favorites

[Servlet]

(05-03-2017, 03:03 PM)nonexist Wrote: hope can play to resident evil 0 wii and resident evil code veronica

RE games are my favorites

Yes, my previous install failed because I still have dolphin master installed, after uninstall dolphin master then my install can work, so the APK is ok actually.

Please try with other RE games.
I'm debugging the RE Remake because I really want to play them on my phone, you can play everywhere + save state is super awesome.

[nonexist]

(05-03-2017, 03:07 PM)Servlet Wrote: Yes, my previous install failed because I still have dolphin master installed, after uninstall dolphin master then my install can work, so the APK is ok actually.

Please try with other RE games.
I'm debugging the RE Remake because I really want to play them on my phone, you can play everywhere + save state is super awesome.

yup i will try when get home

[degasus]

ps_res is supposed to calculate an estimate of 1/x

The jit currently calculates 1/sqrt(x)

This is just an epic fail, and we're currently making fun of it on IRC:
08:25:34 @flacs | uh...
08:25:36 @flacs | FRSQRTE?
08:25:42 @HdkR | lol
08:25:46 @flacs | reciprocal square root?
08:25:51 @HdkR | yea
08:26:01 @HdkR | +estimate
08:26:14 @HdkR |
08:26:36 @flacs | ps_res is just reciprocal...
08:27:11 @HdkR | yep
08:27:15 @HdkR | Gekko is silly
08:27:54 @flacs | heh: {26, &JitArm64::FallBackToInterpreter}, // ps_rsqrte
08:28:25 @HdkR | :3
08:29:53 @flacs | wow, ps_res has been wrong since january 2015
08:29:57 @flacs | i.e. always
08:30:19 @HdkR | oops
08:30:32 @HdkR |

Bad luck, a good implementation is out of scope for now, so I suggest to push the interpreter fallback :/
Very nice catch. It took 5 minutes to see the problem once we know that "ps_res" is the issue. The timing consuming part was all done by Servlet.