• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 32 33 34 35 36 ... 117 Next »

Issue 8317 - Messed up bloom
View New Posts | View Today's Posts

Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Issue 8317 - Messed up bloom
10-28-2015, 02:50 PM
#9
phire Offline
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 31
Threads: 0
Joined: Jan 2014
Ok, I spent some time looking into this. It's clearer what's happening if the image isn't upscaled with bi-cubic sampling.

This 120x112px texture containing initial mask, which has already been downscaled twice (original size, 640x448):
[Image: u2opJFk.png]
Is blured into a 80x56px sub-buffer (which is 160x112px because I'm running dolphin at 2xIR) That buffer is then copied into a 80x56px texture in ram.

[Image: wVGGMfN.png]

The texture is then loaded, as a 40x28px texure.

[Image: bC6zcT0.png]

Because the texture in ram is not a 48x28px texture, we get the wrong result trying to load it. Because of the GameCube's texture format, we get the top 8th of the image, but in a pattern of 4 rows of pixels containing the left half, then 4 rows containing the right half (which is black in this case) repeating. 

Clearly, the previous copy from efb to ram was mean to downscale by 50%, but it didn't. Either because dolphin messed up and didn't downscale, or dolphin had a cpu bug causing the game to never ask for the image to be downscale (or 3rd possibility, this game is actually broken on the a real gamecube too, and nobody noticed.) 
Find
Reply
« Next Oldest | Next Newest »


Messages In This Thread
Issue 8317 - Messed up bloom - TheComet - 10-27-2015, 09:35 AM
RE: Issue 8317 - Messed up bloom - KHg8m3r - 10-27-2015, 01:12 PM
RE: Issue 8317 - Messed up bloom - JMC47 - 10-27-2015, 06:00 PM
RE: Issue 8317 - Messed up bloom - degasus - 10-27-2015, 06:17 PM
RE: Issue 8317 - Messed up bloom - JMC47 - 10-27-2015, 06:23 PM
RE: Issue 8317 - Messed up bloom - TheComet - 10-27-2015, 09:30 PM
RE: Issue 8317 - Messed up bloom - degasus - 10-27-2015, 09:45 PM
RE: Issue 8317 - Messed up bloom - KHg8m3r - 10-28-2015, 03:28 AM
RE: Issue 8317 - Messed up bloom - phire - 10-28-2015, 02:50 PM

  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode