• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Support v
« Previous 1 ... 249 250 251 252 253 ... 1189 Next »

Is EFBToTextureEnable working properly?
View New Posts | View Today's Posts

Pages (2): 1 2 Next »
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Is EFBToTextureEnable working properly?
05-08-2018, 10:02 PM
#1
themanuel Offline
Parasitic Member of the Community
*****
Posts: 828
Threads: 63
Joined: Oct 2009
On previous versions of dolphin, setting this parameter to False would allow the lens flare effect to work properly on MKW but now, turning it on or off doesn't make it work.  I also noticed that the MKW wiki page no longer mentions the issue with the lens flare effect but it's definitely not resolved.
Windows 10 Pro x64  |  i7-9700K @ 4.6-5.0GHz  |  MSI Z370 Gaming Plus  |  MSI RX 5700 8GB Factory-OC  |  16 GB DDR4-3000
Find
Reply
05-09-2018, 10:11 PM
#2
themanuel Offline
Parasitic Member of the Community
*****
Posts: 828
Threads: 63
Joined: Oct 2009
Any MKW players out there willing to test if you can get the lens flare effect when turning off EFBToTextureEanble?
The quickest way to verify is by playing on Luigi's Circuit which has obvious lens flare when looking towards the sun.
Windows 10 Pro x64  |  i7-9700K @ 4.6-5.0GHz  |  MSI Z370 Gaming Plus  |  MSI RX 5700 8GB Factory-OC  |  16 GB DDR4-3000
Find
Reply
05-10-2018, 12:08 AM
#3
Shadorino Offline
Member
***
Posts: 209
Threads: 16
Joined: Oct 2015
I just fired up the game, I can confirm that the lens flare effect is not emulated. I played with every setting, no luck.
Version used : 5.0-7313

The wiki access to the public has been locked since august 2017. Only a handful of people can still edit it. So you shouldn't expect it to be up to date.
OS : Windows 11 Pro
CPU : i7-7700K (4.8 GHz)
GPU : GTX 1080 Ti FTW3 HYBRID (2 GHz)
RAM : G.Skill Trident Z RGB 16 GB DDR4 3000 MHz C14
Dolphin : latest dev
Find
Reply
05-10-2018, 02:23 AM
#4
themanuel Offline
Parasitic Member of the Community
*****
Posts: 828
Threads: 63
Joined: Oct 2009
Thanks for confirming, Shadorino. I understand the wiki page situation. I only brought it up because the comment about lens flare had been on the wiki for years and was suddenly taken off in the last several months so I wasn't sure what that meant.
Windows 10 Pro x64  |  i7-9700K @ 4.6-5.0GHz  |  MSI Z370 Gaming Plus  |  MSI RX 5700 8GB Factory-OC  |  16 GB DDR4-3000
Find
Reply
05-10-2018, 02:47 AM
#5
Shadorino Offline
Member
***
Posts: 209
Threads: 16
Joined: Oct 2015
My first guess would be that it was fixed recently, but broken very soon after. You'd have to test multiple previous builds to check. I suggest using a save state right before you encounter the sun on the Luigi's Circuit. Will speed up the process tremendously Smile
OS : Windows 11 Pro
CPU : i7-7700K (4.8 GHz)
GPU : GTX 1080 Ti FTW3 HYBRID (2 GHz)
RAM : G.Skill Trident Z RGB 16 GB DDR4 3000 MHz C14
Dolphin : latest dev
Find
Reply
05-10-2018, 03:48 AM
#6
JMC47 Offline
Content Producer
*******
Content Creators (Moderators)
Posts: 6,542
Threads: 29
Joined: Feb 2013
I thought the lenses flare was caused by EFB Access to CPU?
Find
Reply
05-10-2018, 03:57 AM (This post was last modified: 05-10-2018, 03:58 AM by themanuel.)
#7
themanuel Offline
Parasitic Member of the Community
*****
Posts: 828
Threads: 63
Joined: Oct 2009
No, it was EFB copies stored to textures that prevented the lens flare from working properly. You can see it here in an old version of the wiki page, under "Configuration".

I'm sure because I played with this quite a lot last year after finding that disabling the hack would eventually cause MK to crash for me so it was a trade-off between getting the lens flare or avoiding crashes. I settled for enabling the hack to avoid crashes at the small cost of losing the lens flare effect. I checked yesterday to see if I could now have both after a few months' worth of dolphin updates but found that the lens flare now doesn't work either way.
Windows 10 Pro x64  |  i7-9700K @ 4.6-5.0GHz  |  MSI Z370 Gaming Plus  |  MSI RX 5700 8GB Factory-OC  |  16 GB DDR4-3000
Find
Reply
05-10-2018, 04:03 AM
#8
JMC47 Offline
Content Producer
*******
Content Creators (Moderators)
Posts: 6,542
Threads: 29
Joined: Feb 2013
We fixed the EFB2RAM crash I'm pretty sure... if it's still happening, please get a backtrace. If you're 100% certain EFB2Tex was working, please bisect to what broke it.
Find
Reply
05-10-2018, 04:13 AM
#9
themanuel Offline
Parasitic Member of the Community
*****
Posts: 828
Threads: 63
Joined: Oct 2009
Sure, I'll check tonight exactly in what version the lens flare stopped working, if that's what you mean. Also, it's good to hear that now disabling the hack won't cause MKW to crash but I'll double check that too. Thanks for your help.
Windows 10 Pro x64  |  i7-9700K @ 4.6-5.0GHz  |  MSI Z370 Gaming Plus  |  MSI RX 5700 8GB Factory-OC  |  16 GB DDR4-3000
Find
Reply
05-10-2018, 09:30 AM
#10
themanuel Offline
Parasitic Member of the Community
*****
Posts: 828
Threads: 63
Joined: Oct 2009
(05-10-2018, 04:03 AM)JMC47 Wrote: We fixed the EFB2RAM crash I'm pretty sure... if it's still happening, please get a backtrace.  If you're 100% certain EFB2Tex was working, please bisect to what broke it.

Hey, JMC.  I was able to narrow it down to 5.0-7151.  That is the first build where the lens flare effect no longer works.  On the build just before that one, 5.0-7146, it works.

The description in the download page for that build reads:
"[color=#333333]Implement copy filter (deflickering/brightness) and XFB gamma ([/color][color=#428bca]PR #6369[/color][color=#333333] from [/color][color=#428bca]stenzek[/color][color=#333333])"[/color]

Let me know if further testing is needed.
Windows 10 Pro x64  |  i7-9700K @ 4.6-5.0GHz  |  MSI Z370 Gaming Plus  |  MSI RX 5700 8GB Factory-OC  |  16 GB DDR4-3000
Find
Reply
« Next Oldest | Next Newest »
Pages (2): 1 2 Next »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode