Is EFBToTextureEnable working properly?

themanuel · 05-08-2018, 10:02 PM #1

On previous versions of dolphin, setting this parameter to False would allow the lens flare effect to work properly on MKW but now, turning it on or off doesn't make it work. I also noticed that the MKW wiki page no longer mentions the issue with the lens flare effect but it's definitely not resolved.

themanuel · 05-09-2018, 10:11 PM #2

Any MKW players out there willing to test if you can get the lens flare effect when turning off EFBToTextureEanble?
The quickest way to verify is by playing on Luigi's Circuit which has obvious lens flare when looking towards the sun.

Shadorino · 05-10-2018, 12:08 AM #3

I just fired up the game, I can confirm that the lens flare effect is not emulated. I played with every setting, no luck.
Version used : 5.0-7313

The wiki access to the public has been locked since august 2017. Only a handful of people can still edit it. So you shouldn't expect it to be up to date.

themanuel · 05-10-2018, 02:23 AM #4

Thanks for confirming, Shadorino. I understand the wiki page situation. I only brought it up because the comment about lens flare had been on the wiki for years and was suddenly taken off in the last several months so I wasn't sure what that meant.

Shadorino · 05-10-2018, 02:47 AM #5

My first guess would be that it was fixed recently, but broken very soon after. You'd have to test multiple previous builds to check. I suggest using a save state right before you encounter the sun on the Luigi's Circuit. Will speed up the process tremendously Smile

**JMC47** · 05-10-2018, 03:48 AM #6

I thought the lenses flare was caused by EFB Access to CPU?

themanuel · (This post was last modified: 05-10-2018, 03:58 AM by themanuel.)

No, it was EFB copies stored to textures that prevented the lens flare from working properly. You can see it here in an old version of the wiki page, under "Configuration".

I'm sure because I played with this quite a lot last year after finding that disabling the hack would eventually cause MK to crash for me so it was a trade-off between getting the lens flare or avoiding crashes. I settled for enabling the hack to avoid crashes at the small cost of losing the lens flare effect. I checked yesterday to see if I could now have both after a few months' worth of dolphin updates but found that the lens flare now doesn't work either way.

**JMC47** · 05-10-2018, 04:03 AM #8

We fixed the EFB2RAM crash I'm pretty sure... if it's still happening, please get a backtrace. If you're 100% certain EFB2Tex was working, please bisect to what broke it.

themanuel · 05-10-2018, 04:13 AM #9

Sure, I'll check tonight exactly in what version the lens flare stopped working, if that's what you mean. Also, it's good to hear that now disabling the hack won't cause MKW to crash but I'll double check that too. Thanks for your help.

themanuel · 05-10-2018, 09:30 AM **#10**

(05-10-2018, 04:03 AM)JMC47 Wrote: We fixed the EFB2RAM crash I'm pretty sure... if it's still happening, please get a backtrace. If you're 100% certain EFB2Tex was working, please bisect to what broke it.

Hey, JMC. I was able to narrow it down to 5.0-7151. That is the first build where the lens flare effect no longer works. On the build just before that one, 5.0-7146, it works.

The description in the download page for that build reads:
"Implement copy filter (deflickering/brightness) and XFB gamma (PR #6369 from stenzek)"

Let me know if further testing is needed.