Implementing joystick plug in notifications on Windows

[Dwedit]

Okay, so I've downloaded the source code, and started writing some code.
So far, I have some working code that registers device notifications for HID devices, mice, and keyboards, and also the windows message handler code that executes when such a device is plugged in.
I've tested it by plugging in the one device I had sitting around (Steam Controller Receiver), and the handler code is getting called when it's plugged in.
I haven't tried bluetooth devices yet.

Just a few more questions...

Do we need to detect the Mayflash GC adapter getting plugged in during run time? I don't know its device class GUID, but could probably find it out later.
What about other kinds of USB devices that would get passed on to Dolphin?
Do we need to handle devices getting removed too?
Do we need an added delay before triggering a joystick rescan?

Then finally...

What do I actually do after the device has been plugged in to perform a joystick rescan? What function do I call?

[ExtremeDude2]

You might want to check out #dolphin-dev on freenode to get in easy contact with devs.

[leolam]

Quote:Do we need to detect the Mayflash GC adapter getting plugged in during run time? I don't know its device class GUID, but could probably find it out later.

No. The GC adapter code is separate from ControllerInterface, which is where the hotplug logic is implemented.

Quote:What about other kinds of USB devices that would get passed on to Dolphin?

ControllerInterface should only care about controllers.

For USB passthrough, we already handle device insertions/removals and communicate these events to the emulated software correctly (AFAIK).

Quote:Do we need to handle devices getting removed too?

Yes.

Quote:Do we need an added delay before triggering a joystick rescan?

Not if you're doing an event-based implementation, i.e. only triggering the hotplug code when a device is actually being inserted/removed.

Quote:What do I actually do after the device has been plugged in to perform a joystick rescan? What function do I call?

I suggest reading evdev.cpp or the macOS implementation for more details, but basically:

* Listen for device change events and figure out what device got added/removed.
* Call g_controller_interface.AddDevice when a device gets inserted
* Call g_controller_interface.RemoveDevice when a device gets removed. You should pass a function that returns true for the device you want to remove, like this.
* On any change, after calling AddDevice/RemoveDevice, call g_controller_interface.InvokeHotplugCallbacks