I am pleased to report that that version works perfectly! Thanks for implementing this. I'm happy my suggestion of SoX turned out to be a useful for you. I hope your work can be added to the master branch.
Now, as far as I can see there are three more sound issues with Dolphin and I'd like to know if you might have an idea as to the causes of them. First is the treble loss that is happening mostly in the mixer per moosehunter's results. Did you see anything in the code that might explain this?
Second is something I would have thought related to the resampling, but now I'm not really sure. As you could see in your spectogram of the Wii system menu music, there are two lines, one each at 15 kHz and 17 kHz. That seems a conspicuous place to have them seeing as those are either side of the 16 kHz Nyquist frequency of the Wii. You can even hear them (assuming you can still hear up that high) as a kind of noisiness not present on the real Wii. You can see that here.
I sample-aligned the recordings and inverted the phase of one of them, then mixed them together so they cancel out and boosted the volume by nearly 20 dB to properly hear the differences between the two. And this does make the noise easily audible. As I've said before, my recording device has a relatively high noise floor and increasing the volume here made that pretty apparent too, so I took a noiseprint of the buzz from the beginning before the music starts and canceled it out in the rest. I've put the pre-and-post noise reduction versions in this zip so you can hear this artifact easily. This happens in other music as well, it's not just the system menu. Do you have any idea what causes this? I wonder if it's present in the audio before it gets to the mixer. This is one of the things I'd like to test with moosehunter's modification to narrow down where it's being introduced.
The last problem is the clicks and crackles that happen sometimes. Here is a zip with volume-matched recordings of a piece of music from my Wii and from Dolphin (using your most recent fix, but it doesn't matter which revision is used, I get clicks in all I've tried). Many are subtle but it shouldn't be too hard to hear them if you're looking for them; some are larger than others, but a really obvious one is at 25.977 seconds in the left channel. If you look at the waveform, it's a short, sharp peak instead of an issue like a repeated sample. There's another at 16.275 seconds. Clicks don't normally look like this. It's always there, every time, any Dolphin version. The Wii recording verifies these clicks are incorrect behavior. What could be causing consistent clicking glitches? Here again, being able to get at the audio pre-mixer would tell us generally at which point this is going wrong.
Now, as far as I can see there are three more sound issues with Dolphin and I'd like to know if you might have an idea as to the causes of them. First is the treble loss that is happening mostly in the mixer per moosehunter's results. Did you see anything in the code that might explain this?
Second is something I would have thought related to the resampling, but now I'm not really sure. As you could see in your spectogram of the Wii system menu music, there are two lines, one each at 15 kHz and 17 kHz. That seems a conspicuous place to have them seeing as those are either side of the 16 kHz Nyquist frequency of the Wii. You can even hear them (assuming you can still hear up that high) as a kind of noisiness not present on the real Wii. You can see that here.
Spoiler: (Show Spoiler)
![[Image: e2ga.png]](http://imageshack.us/photo/my-images/706/e2ga.png/)
I sample-aligned the recordings and inverted the phase of one of them, then mixed them together so they cancel out and boosted the volume by nearly 20 dB to properly hear the differences between the two. And this does make the noise easily audible. As I've said before, my recording device has a relatively high noise floor and increasing the volume here made that pretty apparent too, so I took a noiseprint of the buzz from the beginning before the music starts and canceled it out in the rest. I've put the pre-and-post noise reduction versions in this zip so you can hear this artifact easily. This happens in other music as well, it's not just the system menu. Do you have any idea what causes this? I wonder if it's present in the audio before it gets to the mixer. This is one of the things I'd like to test with moosehunter's modification to narrow down where it's being introduced.
The last problem is the clicks and crackles that happen sometimes. Here is a zip with volume-matched recordings of a piece of music from my Wii and from Dolphin (using your most recent fix, but it doesn't matter which revision is used, I get clicks in all I've tried). Many are subtle but it shouldn't be too hard to hear them if you're looking for them; some are larger than others, but a really obvious one is at 25.977 seconds in the left channel. If you look at the waveform, it's a short, sharp peak instead of an issue like a repeated sample. There's another at 16.275 seconds. Clicks don't normally look like this. It's always there, every time, any Dolphin version. The Wii recording verifies these clicks are incorrect behavior. What could be causing consistent clicking glitches? Here again, being able to get at the audio pre-mixer would tell us generally at which point this is going wrong.