• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 2 3 4 5 6 ... 116 Next »

How to get git write access
View New Posts | View Today's Posts

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
How to get git write access
01-02-2022, 07:56 AM
#1
gordonfreeman01 Offline
Junior Member
**
Posts: 11
Threads: 1
Joined: Jan 2022
Hi, I'm new around here and the search function did not return the answer (Wiki and FAQ also no dice) so asking in a thread: How does someone qualify to get write access to the dolphin repo? The reason I'm asking is I'd like to do an ini update for Tron:_Evolution - Battle Grids so it uses Safe texture cache as the Wiki entry and my own testing confirms is required.

I'd also like to try resolving the merge conflicts for One More Try's Conditional EFB scaling to fix bloom so the changes are available on more recent builds for those who need it.
Find
Reply
01-02-2022, 08:06 AM
#2
JosJuice Offline
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 8,837
Threads: 7
Joined: Oct 2014
Direct write access to the git repo is something that's only granted to trusted contributors who have been in the Dolphin project for a good while. There's no formal process for how to qualify for it.

The normal way to contribute to Dolphin (even for those who do have write access to the git repo) is to open a pull request at https://github.com/dolphin-emu/dolphin. This is available to anyone who has a GitHub account.
Find
Reply
01-03-2022, 02:20 AM
#3
gordonfreeman01 Offline
Junior Member
**
Posts: 11
Threads: 1
Joined: Jan 2022
(01-02-2022, 08:06 AM)JosJuice Wrote: Direct write access to the git repo is something that's only granted to trusted contributors who have been in the Dolphin project for a good while. There's no formal process for how to qualify for it.

The normal way to contribute to Dolphin (even for those who do have write access to the git repo) is to open a pull request at https://github.com/dolphin-emu/dolphin. This is available to anyone who has a GitHub account.

Thanks for clarifying. While I can make a PR for the INI changes, the second scenario I wish to try is resolving merge conflicts in https://github.com/dolphin-emu/dolphin/pull/7533 for which it looks like I would need to make a fork and PR that back in separately rather than add it on top of the existing PR. Would you recommend I do that or contribute changes to the repo with the original changes which is in that PR instead?
Find
Reply
01-03-2022, 02:39 AM
#4
JosJuice Offline
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 8,837
Threads: 7
Joined: Oct 2014
Making a new PR is the standard approach.

Contributing changes to the repo that the original PR was made from is possible if you get permission from the person who owns that repo, but I wonder if it wouldn't just create a bigger mess than making a new PR...
Find
Reply
01-03-2022, 02:56 AM
#5
gordonfreeman01 Offline
Junior Member
**
Posts: 11
Threads: 1
Joined: Jan 2022
(01-03-2022, 02:39 AM)JosJuice Wrote: Making a new PR is the standard approach.

Contributing changes to the repo that the original PR was made from is possible if you get permission from the person who owns that repo, but I wonder if it wouldn't just create a bigger mess than making a new PR...

Yeah, that's why I'm hesitant to do that. I'm considering doing this just so the changes are available for those who want to try this approach, making a new PR would cause duplication so wanted to confirm if that's alright and sounds like it is. I'll give the merge a shot and make a new PR then, thanks!
Find
Reply
« Next Oldest | Next Newest »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode