[Hack Idea] Change EFB copy method on different texture types

[crmt29]

Hello.
I don't know how Dolphin works, but I think this is possible.

In this hack, EFB copy method will be different depending on texture type (C14x2, C4, C8, etc)

This can fix mini-map glitches in ZTP, without slowing down everything.
ZTP uses C14x2 textures to interface, mini-map and etc.

My idea is:

Copy EFB to RAM when texture type is C14x2
Otherwise, copy EFB to texture.

Can something like this work?

Change:

Code:

if(!g_ActiveConfig.bCopyEFBToTexture)

to:

Code:

if(!g_ActiveConfig.bCopyEFBToTexture || (tex_format == GX_TF_C14X2))

There is any good documentation about Dolphin graphic plugins? I'd like to contribute to Dolphin.

Thank you.

PS: I don't speak English very well, sorry.

[Leo]

Cool,this can solve my problem with ZTP,ZWW(Pictobox) and Mario Sunshine(Ink on the floor)!But,just a question:It's possible to make a hotkey for change the EFB between Texture and RAM,instantly?Or it already exists?

[NaturalViolence]

Quote:Or it already exists?

I believe this already exists. Check the "enable hotkeys" checkbox in the advanced tab of your graphics plugin settings.

[Leo]

Yeah,I did it,but...Nothing happens.What's the key?

[crmt29]

(09-17-2010, 04:54 AM)Leo Wrote: Yeah,I did it,but...Nothing happens.What's the key?

1~9 keys.

[Leo]

Oh...

Well...

Common!Let's someone comment about the topic!I really like it,having no slowdowns with almost-perfect graphics,it's very very GOOD!

[KHRZ]

Perhaps post an issue on google code with the suggestion? Or PM hrydgard so he can give you commit rights (if you're planning to do more stuff)

[StripTheSoul]

well, I know the devs don't like hacks very much...however, if this is something that could be made toggleable (does such a word exist? ), why not?

[skid]

(09-16-2010, 07:13 AM)crmt29 Wrote: Change:

Code:

if(!g_ActiveConfig.bCopyEFBToTexture)

to:

Code:

if(!g_ActiveConfig.bCopyEFBToTexture || (tex_format == GX_TF_C14X2))

There is any good documentation about Dolphin graphic plugins? I'd like to contribute to Dolphin.

There's only the code in terms of documentation.

This code is a bit too much of a hack. If there is a way for Dolphin to automatically detect the type of format to use, that would be much better.