Development Thread PixelShader Accurate Overflow Calculation testing

[degasus]

Hi,

I want to change our overflow emulation code of the Pixelshader. As the real hardware uses integers in the TEV, there may be overflows. But current PC hardware always uses floats in shader, so it's hard to emulate the overflows correctly. But the current implementation isn't stable as it overflow at exactly 256.0 instead of the middle of two valid values 255.5.

This change is easy to do, but it's hard to predict (nearly impossible) which regressions it may have. So I need much testing here :-)
As this may also fix other known issues, you could try all known issues which have some random pixel errors.

For all, who want to build the patch yourself: http://pastie.org/8210871
All windows users: win64 win32

Regressions:
Mario Kart Doube Dash
Zelda Twilight Princess

Fixed issues:
3313 - Pink Water Highlights in The Legend of Zelda: The Wind Waker
6391 - Battlefield Backgrounds Flickers Strange Artifacts Intermittently
6442 - Supep Mario Sunshine TEV Issue

[MayImilae]

Tested the Smash Brothers Melee Background flickers and the Super Mario Sunshine TEV issue. Both issues are fixed. I'll test some more games later to check for regressions.

[Starscream]

As explained on IRC, MKDD with OGL doesn't show the Kart and the characters in the bottom box. DX9/11 works. Works with the latest master build, too.

[haddockd]

I love testing Dolphin but I am a little confused. Are you looking for folks to test any game for regressions or is there a specific type of game (or some commonality for the games) that should be tested for regressions?

[neobrain]

The former.

[haddockd]

I tested the following games:
Mario Kart Wii (U)
Dragon Quest Swords (U)
Resident Evil 4 (GC) (U)

All of these games played as they did before. I noticed no graphical anomalies.

[MayImilae]

This has probably already been tested, but the Pink Water at Night issue (3313) in Wind Waker is fixed by this on all backends. As always, I double checked and reproduced it in master just in case.

[Zee530]

(08-07-2013, 10:14 AM)haddockd Wrote: I tested the following games:
Mario Kart Wii (U)
Dragon Quest Swords (U)
Resident Evil 4 (GC) (U)

All of these games played as they did before. I noticed no graphical anomalies.

There's the 'all known issues' link in the first post that you're suppose to follow and test.

[haddockd]

That is simply a list of all the issues ever reported...so I just randomly pick an issue and see if this fix does anything? Sounds a little haphazard

[degasus]

It's more importend to find regressions. So just use this build for lots of games and search for unknown issues.