• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 45 46 47 48 49 ... 116 Next »

Development Thread
 PixelShader Accurate Overflow Calculation testing
View New Posts | View Today's Posts

Pages (2): 1 2 Next »
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Green Notice (Development Thread) PixelShader Accurate Overflow Calculation testing
08-06-2013, 07:17 PM (This post was last modified: 08-08-2013, 08:16 AM by degasus.)
#1
degasus Offline
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,827
Threads: 10
Joined: May 2012
Bug 
Hi,

I want to change our overflow emulation code of the Pixelshader. As the real hardware uses integers in the TEV, there may be overflows. But current PC hardware always uses floats in shader, so it's hard to emulate the overflows correctly. But the current implementation isn't stable as it overflow at exactly 256.0 instead of the middle of two valid values 255.5.

This change is easy to do, but it's hard to predict (nearly impossible) which regressions it may have. So I need much testing here :-)
As this may also fix other known issues, you could try all known issues which have some random pixel errors.

For all, who want to build the patch yourself: http://pastie.org/8210871
All windows users: win64 win32

Regressions:
Mario Kart Doube Dash
Zelda Twilight Princess

Fixed issues:
3313 - Pink Water Highlights in The Legend of Zelda: The Wind Waker
6391 - Battlefield Backgrounds Flickers Strange Artifacts Intermittently
6442 - Supep Mario Sunshine TEV Issue
Find
Reply
08-07-2013, 01:29 AM
#2
MayImilae Offline
Chronically Distracted
**********
Administrators
Posts: 4,572
Threads: 119
Joined: Mar 2011
Tested the Smash Brothers Melee Background flickers and the Super Mario Sunshine TEV issue. Both issues are fixed. I'll test some more games later to check for regressions.
[Image: RPvlSEt.png]
AMD Threadripper Pro 5975WX PBO+200 | Asrock WRX80 Creator | NVIDIA GeForce RTX 4090 FE | 64GB DDR4-3600 Octo-Channel | Windows 11 22H2
MacBook Pro 14in | M1 Max (32 GPU Cores) | 64GB LPDDR5 6400 | macOS 12
Find
Reply
08-07-2013, 01:43 AM (This post was last modified: 08-07-2013, 01:56 AM by Starscream.)
#3
Starscream Away
Above and Beyond
*******
Posts: 4,052
Threads: 213
Joined: Jun 2009
As explained on IRC, MKDD with OGL doesn't show the Kart and the characters in the bottom box. DX9/11 works. Works with the latest master build, too.

[Image: QhzEmR1.jpg]
Asus Laptop: K53TA
OS: Windows 7 Home Premium, 64-Bit - SP1
CPU: AMD Llano A6-3400M, Quad-Core, 1.4GHz-2.6GHz (Overclocked)
GPU: AMD Radeon HD6650M, 1GB GDDR3 (Catalyst 13.1)
RAM: Samsung 4GB DDR3-1333










Find
Reply
08-07-2013, 03:20 AM
#4
haddockd Offline
Dolphin Addict
*****
Posts: 838
Threads: 31
Joined: Jun 2011
I love testing Dolphin but I am a little confused. Are you looking for folks to test any game for regressions or is there a specific type of game (or some commonality for the games) that should be tested for regressions?
i5-8600K @ 4.5 GHz
GeForce GTX 1080 SC2
ASRock Z370 Taichi LGA 1151
CORSAIR Vengeance LPX 16GB 2400 DDR4
SAMSUNG 970 EVO M.2 500GB PCIe SSD
Indigo Xtreme TIM
Phanteks Pro ES614P Black Steel Case
EVGA SuperNOVA 750W PSU
Windows 10 64-bit
Find
Reply
08-07-2013, 03:32 AM
#5
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
The former.
My blog
Me on Twitter
My wishlist on Amazon.de
Find
Reply
08-07-2013, 10:14 AM
#6
haddockd Offline
Dolphin Addict
*****
Posts: 838
Threads: 31
Joined: Jun 2011
I tested the following games:
Mario Kart Wii (U)
Dragon Quest Swords (U)
Resident Evil 4 (GC) (U)

All of these games played as they did before. I noticed no graphical anomalies.
i5-8600K @ 4.5 GHz
GeForce GTX 1080 SC2
ASRock Z370 Taichi LGA 1151
CORSAIR Vengeance LPX 16GB 2400 DDR4
SAMSUNG 970 EVO M.2 500GB PCIe SSD
Indigo Xtreme TIM
Phanteks Pro ES614P Black Steel Case
EVGA SuperNOVA 750W PSU
Windows 10 64-bit
Find
Reply
08-07-2013, 01:57 PM (This post was last modified: 08-07-2013, 03:46 PM by MayImilae.)
#7
MayImilae Offline
Chronically Distracted
**********
Administrators
Posts: 4,572
Threads: 119
Joined: Mar 2011
This has probably already been tested, but the Pink Water at Night issue (3313) in Wind Waker is fixed by this on all backends. As always, I double checked and reproduced it in master just in case.
[Image: RPvlSEt.png]
AMD Threadripper Pro 5975WX PBO+200 | Asrock WRX80 Creator | NVIDIA GeForce RTX 4090 FE | 64GB DDR4-3600 Octo-Channel | Windows 11 22H2
MacBook Pro 14in | M1 Max (32 GPU Cores) | 64GB LPDDR5 6400 | macOS 12
Find
Reply
08-07-2013, 09:23 PM
#8
Zee530 Offline
Above and Beyond
*******
Posts: 1,747
Threads: 12
Joined: Jan 2011
(08-07-2013, 10:14 AM)haddockd Wrote: I tested the following games:
Mario Kart Wii (U)
Dragon Quest Swords (U)
Resident Evil 4 (GC) (U)

All of these games played as they did before. I noticed no graphical anomalies.

There's the 'all known issues' link in the first post that you're suppose to follow and test.
......?????
Find
Reply
08-07-2013, 11:37 PM
#9
haddockd Offline
Dolphin Addict
*****
Posts: 838
Threads: 31
Joined: Jun 2011
That is simply a list of all the issues ever reported...so I just randomly pick an issue and see if this fix does anything? Sounds a little haphazard
i5-8600K @ 4.5 GHz
GeForce GTX 1080 SC2
ASRock Z370 Taichi LGA 1151
CORSAIR Vengeance LPX 16GB 2400 DDR4
SAMSUNG 970 EVO M.2 500GB PCIe SSD
Indigo Xtreme TIM
Phanteks Pro ES614P Black Steel Case
EVGA SuperNOVA 750W PSU
Windows 10 64-bit
Find
Reply
08-07-2013, 11:58 PM
#10
degasus Offline
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,827
Threads: 10
Joined: May 2012
It's more importend to find regressions. So just use this build for lots of games and search for unknown issues.
Find
Reply
« Next Oldest | Next Newest »
Pages (2): 1 2 Next »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode