In \Core\Core\Src\HW\GCMemcard.cpp (line 56), in the function decodeCI8image, there's a comment questioning whether the following line should be calling DecodeCI8 instead of Decode5A3:
// huh, this seems wrong. CI8, not 5A3, no?
tdst[ix] = ColorUtil:
ecode5A3(Common:
wap16(pal[src[ix]]));
In fact, the code is correct, because a CI8 pixel is the index of the color in the palette, which is in RGB5A3 format. The comment can be removed.
// huh, this seems wrong. CI8, not 5A3, no?
tdst[ix] = ColorUtil:
ecode5A3(Common:wap16(pal[src[ix]]));In fact, the code is correct, because a CI8 pixel is the index of the color in the palette, which is in RGB5A3 format. The comment can be removed.