[GC] Star Wars Rogue Squadron II: Rogue Leader

[JMC47]

This will fix the bug once it's merged: https://github.com/dolphin-emu/dolphin/pull/2040

Long story short: I found this bug during Faster MMU (first one) when I was attempting to complete the game, Fiora worked around it. Magumagu rewrote stuff, removed whatever ugly hack she used to make it work, and now it's crashing again.

Now this should be a correct solution.

[Dolphy]

Great! now let's hope they can update the HLE too so the game will run smooth on older hardware too.

[JMC47]

The HLE isn't going to just get fixed. Someone needs to do the leg work to have it fixed properly.

[IceStrike256]

Nice to hear JMC47

[Dolphy]

(02-15-2015, 09:31 PM)JMC47 Wrote: This will fix the bug once it's merged:  https://github.com/dolphin-emu/dolphin/pull/2040

Long story short:  I found this bug during Faster MMU (first one) when I was attempting to complete the game, Fiora worked around it.  Magumagu rewrote stuff, removed whatever ugly hack she used to make it work, and now it's crashing again.

Now this should be a correct solution.

Do you know when this will be merged into master ?

[tueidj]

For that case the "bug" is actually in the game, accessing memory that technically doesn't exist. But it was a launch title and the GC SDK at the time had taken a few shortcuts...

[Fiora]

This is really ironic, because I was convinced for months after that patch that there was no way it could have been correct -- and it turns I was half-right. It only fixed the problem because the game had a bug and accessed invalid physical memory addresses that only worked because of hardware wraparound...

[BatJoe]

(02-18-2015, 02:15 AM)Fiora Wrote: This is really ironic, because I was convinced for months after that patch that there was no way it could have been correct -- and it turns I was half-right. It only fixed the problem because the game had a bug and accessed invalid physical memory addresses that only worked because of hardware wraparound...

Fiora, will you be updating your build with the latest fixes?

I'm holding off updating because I don't want to lose that HLE hack fix.

[Dolphy]

(02-18-2015, 02:18 AM)BatJoe Wrote:

(02-18-2015, 02:15 AM)Fiora Wrote: This is really ironic, because I was convinced for months after that patch that there was no way it could have been correct -- and it turns I was half-right. It only fixed the problem because the game had a bug and accessed invalid physical memory addresses that only worked because of hardware wraparound...

Fiora, will you be updating your build with the latest fixes?

I'm holding off updating because I don't want to lose that HLE hack fix.

If she will update it then hoth wont work anymore, i would say stay with the current build as it runs perfectly fine.

[Fiora]

I rebased pretty much all my old patches this morning, so the build should be updated.