[fix] Fragile (and maybe others), source included

orbb · (This post was last modified: 05-21-2009, 09:23 PM by orbb.)

Hi

I played this morning with the sources of dolphin, and I managed to fix the screen flickering problem in Fragile :p

The basic idea is that I check before each frame is displayed if the frame is black, and I dont display it in this case.

the source included is really basic, it checks only for 5 pixels, it should check for the full screen normally, so some screen wont be displayed... anyway, this is just a fix suggestion, so the devs should try to implement this hack and optimise it Smile

This fix seems to slow the emulation a little, and may break other games...

Ok, here's how to implement it :

- Edit the file source\Plugins\Plugin_VideoOGL\Src\render.cpp

- find the line : OpenGL_SwapBuffers();

- replace it with this piece of code :

// [ fix for Fragile by kamui_kun ...
BYTE pixels [15] ;

glReadPixels(300, 200, 1, 1, GL_RED, GL_BYTE, &pixels[0]);
glReadPixels(300, 400, 1, 1, GL_RED, GL_BYTE, &pixels[1]);
glReadPixels(700, 200, 1, 1, GL_RED, GL_BYTE, &pixels[2]);
glReadPixels(700, 400, 1, 1, GL_RED, GL_BYTE, &pixels[3]);
glReadPixels(500, 300, 1, 1, GL_RED, GL_BYTE, &pixels[4]);
glReadPixels(300, 200, 1, 1, GL_GREEN, GL_BYTE, &pixels[5]);
glReadPixels(300, 400, 1, 1, GL_GREEN, GL_BYTE, &pixels[6]);
glReadPixels(700, 200, 1, 1, GL_GREEN, GL_BYTE, &pixels[7]);
glReadPixels(700, 400, 1, 1, GL_GREEN, GL_BYTE, &pixels[8]);
glReadPixels(500, 300, 1, 1, GL_GREEN, GL_BYTE, &pixels[9]);
glReadPixels(300, 200, 1, 1, GL_BLUE, GL_BYTE, &pixels[10]);
glReadPixels(300, 400, 1, 1, GL_BLUE, GL_BYTE, &pixels[11]);
glReadPixels(700, 200, 1, 1, GL_BLUE, GL_BYTE, &pixels[12]);
glReadPixels(700, 400, 1, 1, GL_BLUE, GL_BYTE, &pixels[13]);
glReadPixels(500, 300, 1, 1, GL_BLUE, GL_BYTE, &pixels[14]);

if((pixels[0] != 0) || (pixels[1] != 0) || (pixels[2] != 0) || (pixels[3] != 0) || (pixels[4] != 0)
|| (pixels[5] != 0) || (pixels[6] != 0) || (pixels[7] != 0) || (pixels[8] != 0) || (pixels[9] != 0)
|| (pixels[10] != 0) || (pixels[11] != 0) || (pixels[12] != 0) || (pixels[13] != 0) || (pixels[14] != 0)
) OpenGL_SwapBuffers();
// ... ]

- compile, and play Smile

student1 · (This post was last modified: 05-22-2009, 12:42 AM by student1.)

(05-21-2009, 09:18 PM)orbb Wrote: Hi

I played this morning with the sources of dolphin, and I managed to fix the screen flickering problem in Fragile :p

The basic idea is that I check before each frame is displayed if the frame is black, and I dont display it in this case.

the source included is really basic, it checks only for 5 pixels, it should check for the full screen normally, so some screen wont be displayed... anyway, this is just a fix suggestion, so the devs should try to implement this hack and optimise it

This fix seems to slow the emulation a little, and may break other games...

Ok, here's how to implement it :

- Edit the file source\Plugins\Plugin_VideoOGL\Src\render.cpp

- find the line : OpenGL_SwapBuffers();

- replace it with this piece of code :

// [ fix for Fragile by kamui_kun ...
BYTE pixels [15] ;

glReadPixels(300, 200, 1, 1, GL_RED, GL_BYTE, &pixels[0]);
glReadPixels(300, 400, 1, 1, GL_RED, GL_BYTE, &pixels[1]);
glReadPixels(700, 200, 1, 1, GL_RED, GL_BYTE, &pixels[2]);
glReadPixels(700, 400, 1, 1, GL_RED, GL_BYTE, &pixels[3]);
glReadPixels(500, 300, 1, 1, GL_RED, GL_BYTE, &pixels[4]);
glReadPixels(300, 200, 1, 1, GL_GREEN, GL_BYTE, &pixels[5]);
glReadPixels(300, 400, 1, 1, GL_GREEN, GL_BYTE, &pixels[6]);
glReadPixels(700, 200, 1, 1, GL_GREEN, GL_BYTE, &pixels[7]);
glReadPixels(700, 400, 1, 1, GL_GREEN, GL_BYTE, &pixels[8]);
glReadPixels(500, 300, 1, 1, GL_GREEN, GL_BYTE, &pixels[9]);
glReadPixels(300, 200, 1, 1, GL_BLUE, GL_BYTE, &pixels[10]);
glReadPixels(300, 400, 1, 1, GL_BLUE, GL_BYTE, &pixels[11]);
glReadPixels(700, 200, 1, 1, GL_BLUE, GL_BYTE, &pixels[12]);
glReadPixels(700, 400, 1, 1, GL_BLUE, GL_BYTE, &pixels[13]);
glReadPixels(500, 300, 1, 1, GL_BLUE, GL_BYTE, &pixels[14]);

if((pixels[0] != 0) || (pixels[1] != 0) || (pixels[2] != 0) || (pixels[3] != 0) || (pixels[4] != 0)
|| (pixels[5] != 0) || (pixels[6] != 0) || (pixels[7] != 0) || (pixels[8] != 0) || (pixels[9] != 0)
|| (pixels[10] != 0) || (pixels[11] != 0) || (pixels[12] != 0) || (pixels[13] != 0) || (pixels[14] != 0)
) OpenGL_SwapBuffers();
// ... ]

- compile, and play

Nice thanks, this might actually also fix games like mega man 9 Smile

! But i think it might be more used as a hack to fix the issue, like an extra option for flicker! Anyway great work Smile

!

orbb · 05-22-2009, 12:47 AM #3

no problem Smile

and yes it could fix some other games, and break others :p
but it really needs to be optimised, by checking all the backbuffer pixels and not just five ...
anyway, it works fine with Fragile, and that was my goal Smile

05-22-2009, 07:28 AM #4

I think this could help digimon world 4's constant screen flickering. I'm gonna go check

death-droid · 05-22-2009, 07:43 AM #5

I'll add this as one of the game hack...
Maybe....

05-22-2009, 08:10 AM #6

how about adding this as an option instead of a hack. You could call it something like remove flicker. Of course before you do that you should probably tweak it a bit

deathtotheweird · 05-22-2009, 11:15 AM #7

This works just fine as long as the game is in full screen mode. Very nice find. Game runs better than expected too. Around 40-60fps at times.

hakunushi · 05-22-2009, 02:30 PM #8

this should be added may fix mario party for nvidia users.

death-droid · (This post was last modified: 05-22-2009, 04:41 PM by death-droid.)

Ok Just editing the hack then i might implement it into the OpenGL plugin(As an option)

EDIT:

Just a little clean up Tongue

Need someone to make sure this works...

Woop's just relized the GL_RED stuff XD
Ok just need to make a quick fix for that Tongue

EDIT2:

Ok can someone try this out pls

Code:

BYTE pixels [14] ;

int  color[3];

color[GL_RED,GL_GREEN,GL_BLUE];

    for (int i = 0;i<14;i++)

    {

        for (int ii = 0;ii<3;i++)

        {

            if (i == 0||5||10)

                glReadPixels(300, 200, 1, 1, color[ii], GL_BYTE, &pixels[i]);

            if (i == 1||6||11)

                glReadPixels(300, 400, 1, 1, color[ii], GL_BYTE, &pixels[i]);

            if (i == 2||7||12)

                glReadPixels(700, 200, 1, 1, color[ii], GL_BYTE, &pixels[i]);

            if (i == 3||8||13)

                glReadPixels(700, 400, 1, 1, color[ii], GL_BYTE, &pixels[i]);

            if (i == 4||9||14)

                glReadPixels(500, 300, 1, 1, color[ii], GL_BYTE, &pixels[i]);

        }

        if(pixels[i]!=0)

        {

            OpenGL_SwapBuffers();

        }

    }

deathtotheweird · 05-22-2009, 04:36 PM **#10**

Getting undeclared identifier from pixels. I'm no programmer so I have no idea how to fix this, or what it means.