• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 45 46 47 48 49 ... 116 Next »

Fix for the random audio pops - please test!
View New Posts | View Today's Posts

Pages (2): 1 2 Next »
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Fix for the random audio pops - please test!
07-12-2013, 10:18 AM (This post was last modified: 07-13-2013, 09:57 PM by delroth.)
#1
delroth Offline
Making the world a better place through reverse engineered DSP firmwares
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,354
Threads: 63
Joined: Aug 2011
Hi everyone,

I think I might have fixed the random audio pops that happen with Dolphin even when your game runs at 100%. TL;DR: test https://dolphin-emu.org/download/dev/32579a08dd74d35647c7a016d190a54aae60b97b/ (mixer-rewrite branch), HLE/LLE shouldn't really matter.

Please test for the 92 minutes audio issue again: it's unlikely to happen again, but we're never too sure Smile

This is mostly untested: instead of fixing random pops, it might also crash, eat your babies, etc.

Thanks!
Pierre "delroth" Bourdon - @delroth_ - Blog

<@neobrain> that looks sophisticated enough to not be a totally dumb thing to do
Website Find
Reply
07-12-2013, 03:19 PM (This post was last modified: 07-12-2013, 05:59 PM by MayImilae.)
#2
MayImilae Offline
Chronically Distracted
**********
Administrators
Posts: 4,572
Threads: 119
Joined: Mar 2011
It's definitely better. Audio pops are gone, I didn't hear a single one. Unfortunately it isn't all good. I have noticed some odd... hiccups? I guess that's a good word to describe it. The music just stops and goes "HICK". It's much much rarer than the old pops problem though. There was no discernible drop in FPS, nothing else going on with the computer, just random HICK. *shrug* It sounds like a stutter in the audio log, but I'm pretty sure it sounded a little different in game.

Here's an audio log. Because of dialup, I had no choice but to trim it down to just one hiccup and a few surrounding seconds. It's mp3, but 320kbps, so it shouldn't have lost too much quality. This problem seems to happen every minute or so give a few seconds, so it shouldn't be hard to replicate.

https://dl.dropboxusercontent.com/u/519564/Mixer%20Rewrite%20Brawl%20Hiccup.mp3

Settings:
DSP LLE
DSP on Thread disabled
Xaudio2

Test:
Super Smash Bros. Brawl NTSC
Lylat Cruise level on pause

EDIT: Tried it with Dsound and another stage. Still there. And it definitely sounds different while playing compared to the log. While playing, it sounds like the audio just stops for a tiny portion of a second then lurches back into play. In the audio logs, it sounds like a stutter. It's much more annoying while playing a game. On to another game!

EDIT2: Happens in Mario Kart Wii. Curiously it didn't seem to happen in Super Mario Sunshine. Perhaps the music style makes it hard to hear? I'm going to try more gamecube games.

EDIT3: Melee and Windwaker both have it. Don't know what was going on with Sunshine. I tested it yet again, and Sunshine still doesn't have the hiccups. *shrug* Can someone please reproduce this so I know I'm not going crazy?

EDIT4: Oh, yea, and it pops every time you start emulation. How did I forget to mention that?
[Image: RPvlSEt.png]
AMD Threadripper Pro 5975WX PBO+200 | Asrock WRX80 Creator | NVIDIA GeForce RTX 4090 FE | 64GB DDR4-3600 Octo-Channel | Windows 11 22H2
MacBook Pro 14in | M1 Max (32 GPU Cores) | 64GB LPDDR5 6400 | macOS 12
Find
Reply
07-12-2013, 06:45 PM
#3
delroth Offline
Making the world a better place through reverse engineered DSP firmwares
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,354
Threads: 63
Joined: Aug 2011
degasus pointed out a few bugs in the implementation this morning - I'll fix most of these issues this evening (~12h from now), that should at least fix the "pop" when starting emulation (noticed that one too, was too lazy to fix in the first iteration of that code Tongue ). Not sure about these random hiccups yet.
Pierre "delroth" Bourdon - @delroth_ - Blog

<@neobrain> that looks sophisticated enough to not be a totally dumb thing to do
Website Find
Reply
07-12-2013, 07:42 PM
#4
isamu Offline
Senior Member
****
Posts: 257
Threads: 9
Joined: Jan 2010
(07-12-2013, 06:45 PM)delroth Wrote: degasus pointed out a few bugs in the implementation this morning - I'll fix most of these issues this evening (~12h from now), that should at least fix the "pop" when starting emulation (noticed that one too, was too lazy to fix in the first iteration of that code Tongue ). Not sure about these random hiccups yet.
Interesting. I wonder if this fixes the popping sounds in F-ZeroGX if it's not running full speed? Let us know guys Smile
Find
Reply
07-12-2013, 10:40 PM
#5
delroth Offline
Making the world a better place through reverse engineered DSP firmwares
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,354
Threads: 63
Joined: Aug 2011
No, that's not a bug. Don't complain about audio not running at full speed if the game does not run at full speed.
Pierre "delroth" Bourdon - @delroth_ - Blog

<@neobrain> that looks sophisticated enough to not be a totally dumb thing to do
Website Find
Reply
07-12-2013, 11:12 PM
#6
haddockd Offline
Dolphin Addict
*****
Posts: 838
Threads: 31
Joined: Jun 2011
I should be able to test your new build tonight when I get home. Looking forward to it!
i5-8600K @ 4.5 GHz
GeForce GTX 1080 SC2
ASRock Z370 Taichi LGA 1151
CORSAIR Vengeance LPX 16GB 2400 DDR4
SAMSUNG 970 EVO M.2 500GB PCIe SSD
Indigo Xtreme TIM
Phanteks Pro ES614P Black Steel Case
EVGA SuperNOVA 750W PSU
Windows 10 64-bit
Find
Reply
07-13-2013, 09:21 AM
#7
haddockd Offline
Dolphin Addict
*****
Posts: 838
Threads: 31
Joined: Jun 2011
I played WW with the above build using LLE (not Dedicated Thread) and about every 1.5 minutes (ish) the sound would simply stop for .5 to 1 second and then start back up.

*Anxiously awaits the new build from delroth*
</salivation>...lol
i5-8600K @ 4.5 GHz
GeForce GTX 1080 SC2
ASRock Z370 Taichi LGA 1151
CORSAIR Vengeance LPX 16GB 2400 DDR4
SAMSUNG 970 EVO M.2 500GB PCIe SSD
Indigo Xtreme TIM
Phanteks Pro ES614P Black Steel Case
EVGA SuperNOVA 750W PSU
Windows 10 64-bit
Find
Reply
07-13-2013, 09:57 PM
#8
delroth Offline
Making the world a better place through reverse engineered DSP firmwares
**********
Developers (Some Administrators and Super Moderators)
Posts: 1,354
Threads: 63
Joined: Aug 2011
New build to test: https://dolphin-emu.org/download/dev/32579a08dd74d35647c7a016d190a54aae60b97b/

This should fix a few issues.
Pierre "delroth" Bourdon - @delroth_ - Blog

<@neobrain> that looks sophisticated enough to not be a totally dumb thing to do
Website Find
Reply
07-13-2013, 11:04 PM
#9
MayImilae Offline
Chronically Distracted
**********
Administrators
Posts: 4,572
Threads: 119
Joined: Mar 2011
Random pops are back. But they're quieter than on master, so it isn't all bad. And the 1min/1.5min hiccups seem to be fixed, though it's hard to tell through the popping. Swat the new problem and the old one sneaks back in >_<.
[Image: RPvlSEt.png]
AMD Threadripper Pro 5975WX PBO+200 | Asrock WRX80 Creator | NVIDIA GeForce RTX 4090 FE | 64GB DDR4-3600 Octo-Channel | Windows 11 22H2
MacBook Pro 14in | M1 Max (32 GPU Cores) | 64GB LPDDR5 6400 | macOS 12
Find
Reply
07-14-2013, 12:21 AM
#10
haddockd Offline
Dolphin Addict
*****
Posts: 838
Threads: 31
Joined: Jun 2011
I can confirm MaJoR's findings. I will say that the pops do sound less pronounced and the hiccups have been eliminated
i5-8600K @ 4.5 GHz
GeForce GTX 1080 SC2
ASRock Z370 Taichi LGA 1151
CORSAIR Vengeance LPX 16GB 2400 DDR4
SAMSUNG 970 EVO M.2 500GB PCIe SSD
Indigo Xtreme TIM
Phanteks Pro ES614P Black Steel Case
EVGA SuperNOVA 750W PSU
Windows 10 64-bit
Find
Reply
« Next Oldest | Next Newest »
Pages (2): 1 2 Next »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode