dok's "FIFO is overflown by Gatherpipe" fix

[Xtreme2damax]

Updated patch for the latest revision.

Not sure if it's correct, tried to manually merge the code in the best I could like it was.

[Xtreme2damax]

I don't know how, but this seems to have broke some audio. The music on the file select screen for Resident Evil 4 (GC) wasn't working, I went frantic reverting the modifications to the HLE plugin, removing optimizations, I spent hours on the svn page looking through various DSP-HLE commits, reverting changes and nothing fixed it until I reverted this patch.

So yeah believe it or not it seems to kill some audio.

[Caleb260]

Does this patch fixes crashes in the 2nd level in STar Wars Bounty Hunter. ?(I can't get past it) It crashes in different places but always crashes.
Using rev 6461

[Legend80]

(11-26-2010, 05:23 AM)Caleb260 Wrote: Does this patch fixes crashes in the 2nd level in STar Wars Bounty Hunter. ?(I can't get past it) It crashes in different places but always crashes.
Using rev 6461

Did you read the thread? You obviously didn't or your question would be answered one way of the other.

These types of questions alway plague these threads. "oh, you got a patch does it fix Pokemon puke edition from crashing when my animal does the reach around?". NOOOO! It fixes what it says it fixes.

Think for yourself kid...

[Jack Frost]

Your patch seems a bit different, X2d. Notably the Idle Skip patch from wherever, and a few inconsistencies in JitIL.cpp - WriteExceptionExit does the same as the block nodchip introduced, the one with Cleanup/CALL/SUB/JMP.
You might wanna try this one: http://pastie.org/1327922

[dephined]

I'm a bit confused, is this thread continuining to develop the patch found at the beginning of this one?: http://forums.dolphin-emu.org/thread-9932-page-1.html

Because I've tried that r5643 patched (http://rapidshare.com/files/397415424/5643Mx32.rar) and I've got no crashes in Wii Sport Resort, instead with Dolphin 2.0, r6277patched (the one at the beginning of this thread) and latest revision (r6480) it always freeze after a while (tried with swordplay, after some time of swinging the sword the game freezes; with r5643 patched I can swing as long as I want...)

If it's not the same patch, I think that patch was underestimated and should be re-introduced in new build at least as a hack (like the Metroid other M one).

Thank you for the attention.

[Jack Frost]

For one, we do not develop the patch, we just keep it compatible with latest changes in SVN.
And this patch will only help with FIFO problems, not random stuff you might see with Wii Sport Resort or whatever. Enable Panic Alerts in an unpatched build and see if you get "FIFO is overflown by gatherpipe" errors - if yes, it will help to use the patched build.

[dephined]

The patch was originally intended to prevent the freezes in Wii Sports resort too (and it seems it did it), but now that fix has gone...

[Xtreme2damax]

(11-27-2010, 10:56 PM)Jack Frost Wrote: Your patch seems a bit different, X2d. Notably the Idle Skip patch from wherever, and a few inconsistencies in JitIL.cpp - WriteExceptionExit does the same as the block nodchip introduced, the one with Cleanup/CALL/SUB/JMP.
You might wanna try this one: http://pastie.org/1327922

I followed this patch:

http://forums.dolphin-emu.org/thread-12569-post-118400.html#pid118400

I only manually patched the files that were recently updated and couldn't be auto-patched by tortoise due to a mismatch.

[dephined]

(11-28-2010, 04:38 AM)Xtreme2damax Wrote:

(11-27-2010, 10:56 PM)Jack Frost Wrote: Your patch seems a bit different, X2d. Notably the Idle Skip patch from wherever, and a few inconsistencies in JitIL.cpp - WriteExceptionExit does the same as the block nodchip introduced, the one with Cleanup/CALL/SUB/JMP.
You might wanna try this one: http://pastie.org/1327922

I followed this patch:

http://forums.dolphin-emu.org/thread-12569-post-118400.html#pid118400

I only manually patched the files that were recently updated and couldn't be auto-patched by tortoise due to a mismatch.

So it's another patch...if someone wants to get Wii Sports Resort fixed should have a look at the link that I posted, because it really seems to fix it (don't know if it breaks someting else though...)