dok's "FIFO is overflown by Gatherpipe" fix

**Xtreme2damax** · 10-27-2010, 10:47 AM **#31**

It needs a bit more testing and feedback, it should be made sure that the patch won't cause any other issues. The patch is also outdated by the way, last time I applied this patch and compiled a build I had to edit a couple of the source files manually. When I decide to apply the patch again, I will offer it over at Xtemulation for download and will test some games myself.

Legend80 · 10-27-2010, 10:50 AM **#32**

(10-27-2010, 10:47 AM)Xtreme2damax Wrote: It needs a bit more testing and feedback, it should be made sure that the patch won't cause any other issues. The patch is also outdated by the way, last time I applied this patch and compiled a build I had to edit a couple of the source files manually. When I decide to apply the patch again, I will offer it over at Xtemulation for download and will test some games myself.

Ok, sounds good! Thanks man!

Jack Frost · (This post was last modified: 10-28-2010, 01:56 AM by Jack Frost.)

Thanks for all the reports.
I was a bit busy the last 2 weeks, so I could not work on Dolphin.

I created a new patch so it can be applied on the last revision (http://pastebin.com/GGf5UhjM)
I also fixed a small performance issue in this new patch.

**Jack Frost** · 10-28-2010, 01:57 AM **#34**

About time you'd commit it I'd say Tongue

Finished SF Adventures in the meantime, and I can only say that the old patch from the mailing list worked like a charm.

**Xtreme2damax** · 10-28-2010, 02:04 AM **#35**

Hehe, Starfox Adventures seems to have core issues. I opened a thread about the issues btw in case any of the developers want to look into it sometime. There may also be an issue that affects Eternal Darkness according to Starscream:

http://forums.dolphin-emu.org/thread-12769.html

Anyways I'll compile and post the build over at Xtemulation for further testing.

**skid** · 10-28-2010, 09:30 AM **#36**

I think the patch should be committed because the reports of "FIFO overflow" are getting annoying.

**Xtreme2damax** · (This post was last modified: 10-28-2010, 10:35 AM by Xtreme2damax.)

(10-17-2010, 06:24 AM)Legend80 Wrote: I'm still getting these messages in "Crash Bandicoot - Wrath of Cortex".

This guy is still claiming he is getting these even with the patch. Maybe he got confused and didn't download one of the actual patched builds I don't know.

Besides the fifo overflown errors aren't crashing the emulator as long as panic handlers are disabled afaik. The errors don't seems to happen with SMG/SMG2 anymore, I only got the error in Starfox Adventures once.

I would say hold off on committing the patch for at least a few or so days to give a chance for testing, besides it seems that idle skipping isn't working with the patch and only causes slowdowns with some games if it is enabled.

I have a patched build up at Xtemulation so if anyone is having a problem they can just be pointed towards here for now:

http://www.xtemu.com/forum/files/category/25-dolphin-svn-builds/

Revision 6316 has the patch applied.

Legend80 · (This post was last modified: 10-30-2010, 10:36 AM by Legend80.)

Just tried with your r6316 and I'm still getting the "fifo overflown" message soon after launching Crash Bandicoot: WoC (during credit screens). So for whatever reason the patch doesn't help the game. So we should definetely leave the "watermark" option until the patch fully rids all games of this issue.

But everything else is working just fine so far. Once the "idle skipping" issue is fixed, let's just commit this and really get this thing tested properly.

**Xtreme2damax** · 10-30-2010, 10:55 AM **#39**

Does the watermark even help this game? It may be having a different issues that neither the patch or the watermark is going to fix. Are you downloading the 6316 build I compiled or someone else compiles, so far only myself and Jack Frost have provided the patched builds.

Legend80 · (This post was last modified: 10-30-2010, 03:07 PM by Legend80.)

(10-30-2010, 10:55 AM)Xtreme2damax Wrote: Does the watermark even help this game? It may be having a different issues that neither the patch or the watermark is going to fix. Are you downloading the 6316 build I compiled or someone else compiles, so far only myself and Jack Frost have provided the patched builds.

Ok, we have a issue here, especially if this goes beyond just this game which one would have to assume. Downloading r6316 from Mamario (no patch), unzipping, and then immediately launching Crash Bandicoot causes no fifo messages. Then adjusting the watermark to 0, 50, 500, 1000 and launching after each still causes no fifo messages.

BUT, using your patched build (which has no watermark option) I receive these fifo messages at several spots every time I boot the title. I get 3-4 before reaching the main menu. So using the patch CAUSES this game to have fifo issues, whereas useing a normal build, I can't get these to reproduce no matter what I try. Not good and pretty concerning that this patch could cause issues where before there were none.