DIY dolphin compile version problem

[Servlet]

I use svn to check out dolphin and updates. I do some small modification here and there on UI to fit my phone need / preference.

The problem is the version number and save state / load state. Somehow save state / load state is version bound. And I cannot get the version to be the same with master one if I generate my signed apk. Also I try git GUI also same problem, seems command git to get version in build.gradle is nor running properly (I test command using CMD is ok).

I also try to hack the core of save state to not check version number, but somehow still save state from master won't load on my apk.

Any pointer where I can achieve this (fixing my version or bypass load state version check correctly) from dev is greatly appreciated.

Thanks

[degasus]

You should be able to disable this check just here: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/State.cpp#L149

But I'd suggest to use ingame save files instead. Don't trust savestates. They're fine if you're in a boss battle, but they may break randomly.

Feel free to ask me on IRC #dolphin-emu @ freenode for more information, I'm always happy about android users being able to compile dolphin on their own (iirc you've number 4...)

[Servlet]

Thanks degasus, I will try modify the State.cpp, save state is super awesome in games like resident evil where save is only on typewritter and ribbon, it saves item slot.

I will also hop on irc, thanks

You're right, I was messing with load as function before and still fail. After I bypass the one that you pointed, it crash when do load state, maybe it was not compatible after all

[JosJuice]

Note that the savestate compatibility isn't based on the normal version number, but on this number that doesn't get updated as often: https://github.com/dolphin-emu/dolphin/blob/8be41d3b7c9c33f7f5d59d5cce9e11335ee8559d/Source/Core/Core/State.cpp#L74

So you should get savestate compatibility with the corresponding version of master as long as you don't modify that number (and as long as you don't modify the actual savestate format, of course). Are you sure that the savestate you're trying to load is from the version of master that your custom build is based on?

[Servlet]

Hi Jos, I download the new master build for android but the version still 5.0-3617, also some changes not implemented yet (it seems the android build on master stuck on 5.0-3617 for a while now).

My custom build is from master svn check out today, where some new improvement from the latest master build available to download (like the overlay icon that response to touch, this not available in master latest for android).

Also I join the IRC chat, but it seems there is no chat activity there, is it normal or I miss some configuration ? I'm new to IRC chat

[nonexist]

(05-18-2017, 04:17 PM)Servlet Wrote: Hi Jos, I download the new master build for android but the version still 5.0-3617, also some changes not implemented yet (it seems the android build on master stuck on 5.0-3617 for a while now).

My custom build is from master svn check out today, where some new improvement from the latest master build available to download (like the overlay icon that response to touch, this not available in master latest for android).

Also I join the IRC chat, but it seems there is no chat activity there, is it normal or I miss some configuration ? I'm new to IRC chat

can you share your build? thx

[JosJuice]

(05-18-2017, 04:17 PM)Servlet Wrote: Also I join the IRC chat, but it seems there is no chat activity there, is it normal or I miss some configuration ? I'm new to IRC chat

It's normal, depending on the time of day and your luck. Sometimes there aren't even any messages for several hours.

[Servlet]

(05-18-2017, 11:31 PM)nonexist Wrote: can you share your build? thx

http://www.droidbin.com/p1bgcsmj4takc39t681ci11pvm3

The only change is that the portrai layout screen voes on top half of your phone, so you can use lower half for controls

To jos, yes there is changes in states number in few commits so I guess the savestate from old version won't work

Also degasus said he will fix the master release so it will not stuck at 5.0-3617

[AnyOldName3]

I'm just going to point out before you get in trouble that you also need to supply the actual changes you made to Dolphin's source with any build. It's one of the requirements of the GPL.

[JosJuice]

(05-19-2017, 01:58 AM)AnyOldName3 Wrote: I'm just going to point out before you get in trouble that you also need to supply the actual changes you made to Dolphin's source with any build. It's one of the requirements of the GPL.

Almost. You technically need to supply the full source code, not just the changes (not that anyone here likely would care about enforcing it).