Disable logs for a nice speedup

[RachelB]

(08-26-2014, 08:26 PM)Link_to_the_past Wrote: Only if the log is spammed by an error message/warning performance was seriously affected, so unless a game got spammed by an error in it's log it wouldn't seriously affect performance.

This isn't related to the log itself, but a function used for debugging that doesn't run if this log is disabled.

[DaRkL3AD3R]

Alright so I can easily reproduce a major drop in performance now toggling these logs on and off while a game is running. Just load up 1080 Avalanche and sit at the main menu. Make sure the frame-rate limiter is set to Off and then toggle all the logs on and off back and forth and watch your frame-rate plummet hardcore when you enable the logs.

Now the problem is, for some odd reason, logging likes to re-enable itself every freaking time I end emulation. I have to constantly disable logs in order to prevent the performance loss.

Can you guys fix this please?


Update 9/2/2014 - 1:10 AM

I downloaded build 2848 which disables all logs by default. That works on paper, but in actuality the glitch that is causing massive performance loss from logging, is still there. You can test it the same way. Open 1080 Avalanche and hit the main menu. Now, press the button to toggle all logging on and off, and watch how the performance skyrockets after enabling the logs followed by disabling them.

Something is still bugged with the logger and it's screwing up performance despite all logs being "disabled."

[zephyrsurfer]

(09-01-2014, 05:16 PM)DaRkL3AD3R Wrote: I downloaded build 2848 which disables all logs by default. That works on paper, but in actuality the glitch that is causing massive performance loss from logging, is still there. You can test it the same way. Open 1080 Avalanche and hit the main menu. Now, press the button to toggle all logging on and off, and watch how the performance skyrockets after enabling the logs followed by disabling them.

Something is still bugged with the logger and it's screwing up performance despite all logs being "disabled."

Hiya, I can confirm that. Enabling and disabling the "File Monitor" log more than triples my speed at the main menu and nearly the same in-game with no frame limiter.

Going from ~40 FPS to ~115 FPS in 1080 Avalanche (OpenGL and LLE). Nice one!

It seems the update disabling all logs needs another fix.

[RachelB]

(09-01-2014, 05:16 PM)DaRkL3AD3R Wrote: I downloaded build 2848 which disables all logs by default. That works on paper, but in actuality the glitch that is causing massive performance loss from logging, is still there. You can test it the same way. Open 1080 Avalanche and hit the main menu. Now, press the button to toggle all logging on and off, and watch how the performance skyrockets after enabling the logs followed by disabling them.

Something is still bugged with the logger and it's screwing up performance despite all logs being "disabled."

Being slow isn't a bug. Just leave it disabled.

[DaRkL3AD3R]

(09-04-2014, 07:26 AM)RachelB Wrote: Being slow isn't a bug. Just leave it disabled.

No I don't think you understand. Me and zephyr both confirmed something is wrong with the File Monitor log. Even when the Log Configuration menu shows that it is disabled, it really isn't. If you flip it to on, then off again, you'll see the performance skyrocket as it should when the log is disabled. Something is messed up with the Log Configuration in that it shows logs as being disabled, when really they aren't. Or maybe it's something else in the code that's broken pertaining to logging. I don't know what exactly the error is but it's not playing nice.

And when we are able to nearly triple our performance, no I don't think it is intended. Something is definitely wrong there. We WANT logging to be totally disabled, but it doesn't maintain that "off" state that we (and now Dolphin) set.

[cexikitin]

(09-04-2014, 08:12 AM)DaRkL3AD3R Wrote:

(09-04-2014, 07:26 AM)RachelB Wrote: Being slow isn't a bug. Just leave it disabled.

No I don't think you understand. Me and zephyr both confirmed something is wrong with the File Monitor log. Even when the Log Configuration menu shows that it is disabled, it really isn't. If you flip it to on, then off again, you'll see the performance skyrocket as it should when the log is disabled. Something is messed up with the Log Configuration in that it shows logs as being disabled, when really they aren't. Or maybe it's something else in the code that's broken pertaining to logging. I don't know what exactly the error is but it's not playing nice.

And when we are able to nearly triple our performance, no I don't think it is intended. Something is definitely wrong there. We WANT logging to be totally disabled, but it doesn't maintain that "off" state that we (and now Dolphin) set.

Confirm. I made a video to demonstrate the issue still exists:

http://hiberniagaming.net/1080.mp4

(Was watching community in the background wheeee)

[JMC47]

A feature was added so that all logs were disabled by default.

[cexikitin]

Sorry, didnt notice that i only selected inner window. Made that video with version 4.0-2931-x64 which is after the commit for disabling logs by default.

Edit
Here is a second video, with title visible. Also, shows that "File Monitor" is still the one causing the delay.

http://hiberniagaming.net/1080-2.mp4

[RachelB]

Okay, that's weird.

[cexikitin]

Opened a ticket on the issue tracker.

https://code.google.com/p/dolphin-emu/issues/detail?id=7616&thanks=7616&ts=1409786334