Problem
Same as in Core > Reliable anti-deadlock hack
Solution
Run Stop() from a thread so that the GUI doesn't lock-up in case of a deadlock. This means the users doesn't have to open the Task Manager to end Dolphin in case of a deadlock. Instead Dolphin can be closed in a normal way, when the user notices that the program has deadlocked. However, the program may crash when Dolphin is closed during a deadlock, in that case this solution is not much superior to a timer for WaitForSingleObject(), which was removed in r4803.
I definitely think this patch should be applied, and r4803 reverted, pending further debugging of the deadlocks.
However, I prefer the previous anti-deadlock hack because it should be 100% reliable and never allow a deadlock.
Same as in Core > Reliable anti-deadlock hack
Solution
Run Stop() from a thread so that the GUI doesn't lock-up in case of a deadlock. This means the users doesn't have to open the Task Manager to end Dolphin in case of a deadlock. Instead Dolphin can be closed in a normal way, when the user notices that the program has deadlocked. However, the program may crash when Dolphin is closed during a deadlock, in that case this solution is not much superior to a timer for WaitForSingleObject(), which was removed in r4803.
I definitely think this patch should be applied, and r4803 reverted, pending further debugging of the deadlocks.
However, I prefer the previous anti-deadlock hack because it should be 100% reliable and never allow a deadlock.