Conditional EFB scaling to fix bloom

[zombie167]

Amazing!Work like a charm.Shimmering has appeared but it is acceptable.


The last Story 6XIR

https://www.youtube.com/watch?v=Q6QPWPB4_vc&t=13s

Spoiler: (Show Spoiler)

Before




After

[One More Try]

Great to see another game is improved by it. As for the shimmer, I'm not sure, but maybe applying some sort of Gaussian blur to the upscaled EFB copy, rather than shrinking it, would prevent shimmer. You wouldn't want to do it to all EFB copies though, so it'd still be filtered with a slider. Unfortunately I don't know how to do that.

I noticed the rpcs3 (ps3) emulator also has an EFB copy slider to fix issues with small EFB copies. I don't think they are bloom issues, so maybe they will eventually remove the need for it, but interesting to see it applied in another emulator.

[zombie167]

(04-02-2019, 05:10 PM)One More Try Wrote: Great to see another game is improved by it.  As for the shimmer, I'm not sure, but maybe applying some sort of Gaussian blur to the upscaled EFB copy, rather than shrinking it, would prevent shimmer.  You wouldn't want to do it to all EFB copies though, so it'd still be filtered with a slider. Unfortunately I don't know how to do that.

I noticed the rpcs3 (ps3) emulator also has an EFB copy slider to fix issues with small EFB copies. I don't think they are bloom issues, so maybe they will eventually remove the need for it, but interesting to see it applied in another emulator.

The art style of this game is full of rich bloom effects,I think those shimmerings are acceptable. Just think of it as part of the bloom effect.I don't like Gaussian blur that makes a blur image.
The custom resolution option(Resolution Scale Threshold) of rpcs3 ,one of the functions can be used to eliminate the over-bloom effect.Maybe it is used to adjust the texture size to match the resolution.It affects the lighting effect and the quality of the texture,whether the texture can be rendered normally or not.

[Silent Hell]

Do you have any plans to rebase this into the dev versions of Dolphin? It certainly is a better alternative than using cheats. Even if it gets hidden as an INI option.

[matheusstaffa]

This is amazing! Is there anyway to active this on skyward Sword on master builds? Or at least, a gecko code for bloom resolution?

[Skroop]

Hey! Just want to say thanks for this, it works amazingly well.

I've been using it with Twilight Princess after having some graphical issues with your Gecko code:
https://forums.dolphin-emu.org/Thread-twilight-princess-bloom-fix-causing-graphical-bug

The slider works like a charm and now I can finally play this game nearly perfectly at higher resolutions!

I currently have the slider at 155, but 215 and 302 also work well. I feel 155 captures the look of the bloom closest to having Scaled EFB off. Messing around with the slider you can see there are incremental points where you can see it "switch" scaling. I'm guessing that's all the textures of the same resolution changing at that point.

[SonicoXXI]

There is no way to exclude a texture by name? not because of its size.
(I speak Spanish translated by google)
---------------------------------------------------------------------------------------------
No hay una forma de excluir una textura por su nombre? no por su tamaño.

[JosJuice]

(08-09-2020, 05:40 PM)SonicoXXI Wrote: There is no way to exclude a texture by name? not because of its size.
(I speak Spanish translated by google)
---------------------------------------------------------------------------------------------
No hay una forma de excluir una textura por su nombre? no por su tamaño.

From the perspective of the GPU, textures don't have names. You can however check the memory address or hash the texture.

[SonicoXXI]

(08-09-2020, 07:15 PM)JosJuice Wrote: From the perspective of the GPU, textures don't have names. You can however check the memory address or hash the texture.

Great. Wouldn't that be the beginning of creating a custom graphics pack for each game? In some similar way they solved it in Cemu, the bloom problems to big resolutions.

(translated by Google)
-----------------------------------------------------------------------------------------------------------------
Genial. ¿Eso no sería el comienzo para crear un paquete gráfico personalizado para cada juego? De alguna forma similar lo resolvieron en Cemu, los problemas de floración a grandes resoluciones.

[SeiBiT]

(04-15-2019, 12:14 PM)Silent Hell Wrote: Do you have any plans to rebase this into the dev versions of Dolphin? It certainly is a better alternative than using cheats. Even if it gets hidden as an INI option.

I think it should be merged to the main dolphin codebase, it's so important for a lot of games and it works really well.