(05-02-2018, 05:18 AM)degasus Wrote: You need to create a github account and to close our repository there. Afterwards, you can add this clone as a new remote to you local repository and push your new commits there.
But honestly, explaining git here on the forum is likely not the best way. There are plenty of tutorials online, or you could ask on IRC. I'm also fine with the plain patch, so I could create the pull requests myself.
I did create a public repo in march:
https://github.com/Gerdya/dolphin-gerdya
But i assume i did just some wrong steps. So yup, i guess i need to read up more.
(05-02-2018, 05:18 AM)degasus Wrote: Have you read my comment about dropping the line with W18? We use the 32bit register notation there, but W18 == X18 ( != Q18, this is a NEON register ) https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/PowerPC/JitArm64/JitArm64_RegCache.cpp#L341
Sorry, you already told me before...i did not dare to ask what you meant with "drop register w18". In any case it is now commented out and not available for allocation anymore.
Now the crash in NTDLL is gone
The next crashes have to do with code generation. I did figure out the following as far:
1) X28 is used as memory base address
2) It is intialized in JitAsm.cpp (note MEM_REG = X28)
// set the mem_base based on MSR flags
LDR(INDEX_UNSIGNED, ARM64Reg::W28, PPC_REG, PPCSTATE_OFF(msr));
FixupBranch physmem = TBNZ(ARM64Reg::W28, 31 - 27);
MOVP2R(MEM_REG, Memory::physical_base);
FixupBranch membaseend = B();
SetJumpTarget(physmem);
MOVP2R(MEM_REG, Memory::logical_base);
SetJumpTarget(membaseend);
Indeed, the content of X28 is equal to logical_base, so this works. However *logical_base is not accessible -> so i get an access violation on each load and store using X28.
I do see where physical_base is allocated/comitted, however i do not see where logical_base is allocated or comitted. Any hints?
Thanks,
Gerdya