Commit 5.0-5684 PR8107 should be reverted

[buffsee]

rotating your screen causes the entire emulator to freeze, and whatever was on your screen when it froze will stay even after you've closed the application.

https://i.imgur.com/DyJjA7M.jpg

[Nintonito]

(10-25-2017, 12:43 PM)buffsee Wrote: rotating your screen causes the entire emulator to freeze, and whatever was on your screen when it froze will stay even after you've closed the application.

https://i.imgur.com/DyJjA7M.jpg

I....oh wow holy crap it actually does. It does clear from the frame after the application is closed for me though.

[Helios]

that's amazing

[hackbar]

What phone and OS version did this happen on?

[Nintonito]

(10-25-2017, 05:41 PM)hackbar Wrote: What phone and OS version did this happen on?

His UI suggests he’s either on OP3 or OP5. I tested on Lenovo K8 Note tuning 7.1.1 with a totally different driver stack and mine crashes as well, however the application is cleared correctly after a few seconds. I don’t know why his is different, it may be possible the application isn’t being removed from memory. The crash bug is 100% there though, rotating causes the issue every time on multiple devices.

[JonnyH]

I *hope* it's just that the previous buffer is still being drawn using the hwcomposer - probably cleared to transparent alpha - not that it's actually able to write to other app's buffers from dolphin. The security implications of that would be... worrying

[Nintonito]

(10-26-2017, 04:28 AM)JonnyH Wrote: I *hope* it's just that the previous buffer is still being drawn using the hwcomposer - probably cleared to transparent alpha - not that it's actually able to write to other app's buffers from dolphin. The security implications of that would be... worrying

Android requires a permission to render in those instances, one that dolphin does not ask for. This is definitely not an active exploit, more just a severe rendering bug. The rendering clears up on Mali drivers it seems, and other apps can then render without issue. It may be an issue with how oxygen OS handles apps crashing, because I notice that my device will show a dialog box about the app crash, and during that period the framebuffer is still whacked, but upon selecting “close app” in the dialog box, the buffer is completely cleaned.

[hackbar]

This should be fixed with PR6139. Please test the APK at https://dl.dolphin-emu.org/prs/pr-6139-dolphin-latest.apk.

[buffsee]

(10-26-2017, 06:03 AM)hackbar Wrote: This should be fixed with PR6139. Please test the APK at https://dl.dolphin-emu.org/prs/pr-6139-dolphin-latest.apk.

This works perfectly on my OP5, except games now run in the background when i close. Like I can still hear the game in the background. This could be intentional, but before it would pause.

[hackbar]

That's not intentional, they should be paused. I'll look into it tonight.