cmakelist changes for opencl on linux

[algarues]

I have been compiling dolphin on linux for a while

i have the opencl headers installed, as well as an nvidia cards

however, by looking at the cmakelist, it seems to me that opencl can be compiled only for mac

am I wrong?

could anyone suggest a modification to enable compilation of opencl also on linux?

[Shonumi]

Have you actually tried compiling it on Linux? I've been building Dolphin myself for the past year, and so far it's always compiled the OpenCL texture decoder just fine (though it's not particularly useful in its current state). Which part of the CMakeList.txt are you looking at (it's the one in the root directory of the git repo, right?)

If you look carefully at Line 480, it appears CMake will try to find existing libraries for OpenCL (which I assume includes the headers) on OS X. For everything else, looks like Dolphin just pulls the files from Externals. It should still be possible to compile the OpenCL texture decoder regardless of OS. I'm not very experienced in reading CMake scripts, so hopefully a dev will expand and correct what I've said.

[algarues]

Have you actually tried compiling it on Linux? I've been building Dolphin myself for the past year, and so far it's always compiled the OpenCL texture decoder just fine (though it's not particularly useful in its current state). Which part of the CMakeList.txt are you looking at (it's the one in the root directory of the git repo, right?)

If you look carefully at Line 480, it appears CMake will try to find existing libraries for OpenCL (which I assume includes the headers) on OS X. For everything else, looks like Dolphin just pulls the files from Externals. It should still be possible to compile the OpenCL texture decoder regardless of OS. I'm not very experienced in reading CMake scripts, so hopefully a dev will expand and correct what I've said.

I made the post because I read exactly what you mentioned in line 480
thus it seems to me that upon configuration, cmake only checks for opencl headers only on osx

[neobrain]

OpenCL doesn't have any specific build requirements on Linux, support gets compiled in and enabled on the fly depending on runtime support.

How do you think to know OpenCL is not enabled in your build, anyway?

[algarues]

OpenCL doesn't have any specific build requirements on Linux, support gets compiled in and enabled on the fly depending on runtime support.

How do you think to know OpenCL is not enabled in your build, anyway?

That was exactly the question
how do I find out whether it is enabled or not in the end?
Simply because I get the opencl option available in the configuration dialog?

[neobrain]

I think it's not visible at all unless you add some code modifications to make Dolphin explicitely tell you.

[algarues]

I think it's not visible at all unless you add some code modifications to make Dolphin explicitely tell you.

anyway, below there is the output that I get when running cmake ..
it seems to me that upon configuration there is not detection for the opencl libraries and headers that I have installed

Code:

The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Git: /usr/bin/git (found version "1.7.10.4")
-- Performing Test NO_UNUSED_RESULT
-- Performing Test NO_UNUSED_RESULT - Success
-- Performing Test VISIBILITY_INLINES_HIDDEN
-- Performing Test VISIBILITY_INLINES_HIDDEN - Success
-- Performing Test VISIBILITY_HIDDEN
-- Performing Test VISIBILITY_HIDDEN - Success
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26")
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/x86_64-linux-gnu/libX11.so
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libGL.so  
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp  
OpenMP parallelization enabled
-- Found ALSA: /usr/lib/x86_64-linux-gnu/libasound.so (found version "1.0.25")
ALSA found, enabling ALSA sound backend
ao found, enabling ao sound backend
bluez found, enabling bluetooth support
PulseAudio found, enabling PulseAudio sound backend
-- Could NOT find OpenAL (missing:  OPENAL_LIBRARY OPENAL_INCLUDE_DIR)
OpenAL NOT found, disabling OpenAL sound backend
X11 found
Xrandr found
-- checking for modules 'libavcodec>=53.35.0;libavformat>=53.21.0;libswscale>=2.1.0;libavutil>=51.22.1'
--   found libavcodec, version 54.59.100
--   found libavformat, version 54.29.104
--   found libswscale, version 2.1.101
--   found libavutil, version 51.73.101
libav found, enabling AVI frame dumps
-- Performing Test PORTAUDIO
-- Performing Test PORTAUDIO - Failed
PortAudio not found, disabling mic support
Using static lzo from Externals
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found.
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE  
-- Could NOT find SDL2 (missing:  SDL2_LIBRARY SDL2_INCLUDE_DIR)
-- Found SDL: /usr/lib/x86_64-linux-gnu/libSDLmain.a;/usr/lib/x86_64-linux-gnu/libSDL.so;-pthread  
Using shared SDL
Could NOT find SFML (missing:  SFML_INCLUDE_DIR)
Using static SFML 1.5 from Externals
Using static SOIL from Externals
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.7")
Using shared zlib
GLEW found
Cg found
CgGL found
-- Found wxWidgets: TRUE  
Found wxWidgets version 2.8.12
At least 2.9.3 is required; ignoring found version
-- Found Freetype: /usr/lib/x86_64-linux-gnu/libfreetype.so (found version "2.4.9")
-- Found GTK2_GTK: /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so  
Using static wxWidgets from Externals
gthread-2.0 found
pangocairo found
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1")
-- Configuring done
-- Generating done
-- Build files have been written to:

[neobrain]

Again, OpenCL isn't a build requirement on linux so it's expected that you don't see anything there.

[algarues]

Again, OpenCL isn't a build requirement on linux so it's expected that you don't see anything there.

anyway whether i select or not the opencl option in the video config nothing changes at the level of emulation speed

similarly for other options

e.g. ztp hack does not change any of the emulation speed in hyrule fields (GC version)

I am trying to understand whether any of this is compilation dependent

[Shonumi]

anyway whether i select or not the opencl option in the video config nothing changes at the level of emulation speed

The OpenCL texture decoder is actually slower than the SSE2 optimized one, or something like that. IIRC, it could run better if someone decided to code it to use a more recent version of OpenCL. You're not really going to see any benefit in using OpenCL right now.

e.g. ztp hack does not change any of the emulation speed in hyrule fields (GC version)

I am trying to understand whether any of this is compilation dependent

That's probably because your system is running Hyrule Field as best as it currently can. Though, that's hard to say for sure, since we can't see what kind of hardware you're running (unless you post it). In any case, the ZTP hack is part of Dolphin's code; as long as you don't remove the related code, it gets compiled.