Can it be done?

[Maverick Hunter X]

I have a question and it can seem a bit odd I guess but I'm itchy to try something out just for fun.

So with the upcoming release of Dolphin 5.0 I have read that the re-implementation of the New Zelda HLE (Pull request #2846) is not to be included nor the Remove timing information from DSP-HLE ucode emulation (Pull request #2875) fix.

My question is this, can I include these pull requests to the latest Stable source branch that I downloaded explicit for myself only or is it impossible?

I already have my original DSP dumps from my Wii that I use for LLE but I want to make my own 5.0 release with these PR's so I can use whatever I want whenever I want.

I have a fairly good idea of how to do it, but I just want to know if it's possible or not.

Thanks in advance!

[mimimi]

I assume it might be really difficult to merge, but it's not impossible.

But what exactly is the reasoning behind not just using the development builds?

[JosJuice]

Depending on how the code's been changed, there might be anything from no merge conflicts to lots of merge conflicts. My guess is that the new Zelda HLE won't be too hard to merge, though I don't know for sure. Give it a try if you want to.

[Maverick Hunter X]

I asked myself yesterday, Can it be done?

The answer is, YES it can be done and it has been done!

I have successfully integrated/merged these 2 PR's to the Stable source branch and the sound is awesome!

With my own BIOS dump now recognizable and these 2 PR's included I guess I can start wrapping this up and make my own 5.0 release.

Yes I know I'm crazy and all this sounds retarded, but this was quite an achievement for me and I'm proud that I did it.

[JosJuice]

Sounds good, as long as you don't try to pass it off as the official 5.0 release anywhere

[Maverick Hunter X]

(09-15-2015, 08:24 PM)JosJuice Wrote: Sounds good, as long as you don't try to pass it off as the official 5.0 release anywhere

Don't worry I will keep this strictly to myself!

I've tested quite a few of the Zelda µcode games and it sounds really good.

Here's a screenshot of my unofficial Dolphin 5.0 release (Based on 5.0-rc27) in action:

Spoiler: (Show Spoiler)

[Maverick Hunter X]

(09-15-2015, 03:23 AM)mimimi Wrote: I assume it might be really difficult to merge, but it's not impossible.

But what exactly is the reasoning behind not just using the development builds?

Well for starters, development builds tends to be a bit more unstable so I usually stay away from them and use stable releases instead (that's my general philosophy for most emulators and software I use)

And no I don't use 4.0.2 anymore so don't worry.

I usually pick a specific build and stick with it for a while, it get quite tedious changing all the time.

As for Dolphin 5.0, I have used it since RC1 up to RC27 and have had very little problems with it so far and I have even managed to find time to beat some games too (Metroid Prime 2 Echoes, Metroid Prime, Super Mario Sunshine just to name a few)

The official Dolphin 5.0 release will not have the new Zelda HLE which is really sad because it works really great and many like me that prefers stable releases instead of development builds will miss out on it.
I just tried Four Swords Adventures and to be able to hear the echoes in a cave and to have proper sound with HLE is a huge satisfaction compared to how it sounds in 5.0-rc27.

So that's why I did it because after 5.0 is out it will take quite some time before a new stable release is out and to wait for it with the new Zelda HLE is out of the question for me so I rather take my own unofficial 5.0 release with it instead.

[AnyOldName3]

In the context of releases, a stable release just means that it has no bugs that the previous release didn't have, and that enough testing has been done to guarantee that this is the case. There's no guarantee that it has fewer bugs than a dev build. If a pull request were to be submitted that fixed every bug in Dolphin but introduced a new one where one particular pixel was always slightly darker than it was supposed to be, this would be desired by most users, and probably most of the devs if the code was clean, but it could never be included in a stable release. The stable release isn't for the benefit of the users, but is more an excuse for people to do proper regression testing and also to allow organisations like Debian linux to update the Dolphin builds they have in their repositories, as they'd rather deal with a hundred known critical bugs than one unknown minor one.