Audio in Dolphin

jordm.s · 06-21-2009, 04:26 AM **#51**

(06-21-2009, 04:24 AM)cmccmc Wrote: you need to relax

If my tone came off as angry then I'm sorry, I'm not. MusicMod just doesn't make any sense to me and I was hoping that someone could explain to me why there is work being done on it.

**Xtreme2damax** · (This post was last modified: 06-21-2009, 04:41 AM by Xtreme2damax.)

(06-21-2009, 03:59 AM)jordm.s Wrote: Just looking at the latest SVNs, I see that the devs are doing things with MusicMod again, why? What's the point of MusicMod when the HLE DSP is actually showing progress? Why waste time adding in some stupid hack again when there could be more done making the real thing work?

I agree, I even commented on it at Ngemu. A lot of reputable coders are not happy with John Peterson and music mod since it's a very hackish and inaccurate way to get sound working. It also adds unnecessary bloat to the repository, wasting space so everyone has to download that much more from the repository to compile.

It also never worked properly, and still doesn't seem to work properly. Not to mention I get build errors when trying to compile it where the normal builds compile just fine.

There is really no reason for music mod now that real progress is being made on the dsp plugin, and you can now actually hear some sound in Zelda/Mario games.

Time would be much better spent focusing on the dsp plugin, than wasting time with hackish workarounds such as the music mod. I really thought for sure that the music mod would stay off of the repository for good.

Can't any of the leading developers inform JP to keep the music mod off of the official repository, especially since there is actual progress being made on the dsp plugin which will make music mod useless and pointless?

thegamefreak0134 · 06-21-2009, 06:17 AM **#53**

(06-21-2009, 04:37 AM)Xtreme2damax Wrote:
(06-21-2009, 03:59 AM)jordm.s Wrote: Just looking at the latest SVNs, I see that the devs are doing things with MusicMod again, why? What's the point of MusicMod when the HLE DSP is actually showing progress? Why waste time adding in some stupid hack again when there could be more done making the real thing work?

I agree, I even commented on it at Ngemu. A lot of reputable coders are not happy with John Peterson and music mod since it's a very hackish and inaccurate way to get sound working. It also adds unnecessary bloat to the repository, wasting space so everyone has to download that much more from the repository to compile.

It also never worked properly, and still doesn't seem to work properly. Not to mention I get build errors when trying to compile it where the normal builds compile just fine.

There is really no reason for music mod now that real progress is being made on the dsp plugin, and you can now actually hear some sound in Zelda/Mario games.

Time would be much better spent focusing on the dsp plugin, than wasting time with hackish workarounds such as the music mod. I really thought for sure that the music mod would stay off of the repository for good.

Can't any of the leading developers inform JP to keep the music mod off of the official repository, especially since there is actual progress being made on the dsp plugin which will make music mod useless and pointless?

Amen.

06-21-2009, 06:36 AM **#54**

(06-21-2009, 04:37 AM)Xtreme2damax Wrote: It also adds unnecessary bloat to the repository, wasting space so everyone has to download that much more from the repository to compile.

Quit whining. DSPSpy/DSPTool is also useless to most people, but it's still in the trunk.

**nosound97** · 06-21-2009, 06:40 AM **#55**

DSPSpy actually helps in fixing DSP for devs. AFAIK, it generates a file in the source code that is needed in DSP (if you compiled Dolphin yourself).

But blame me, I could be wrong >.<

06-21-2009, 06:42 AM **#56**

(06-21-2009, 06:40 AM)nosound97 Wrote: DSPSpy actually helps in fixing DSP for devs. AFAIK, it generates a file in the source code that is needed in DSP (if you compiled Dolphin yourself).

But blame me, I could be wrong >.<

Yes, but in a public trunk (where users usually checkout from) it's pretty useless. I mean, it's fine it's there, but like Xtreme2damax is saying, it's "bloat" to non-devs. Tongue

**nosound97** · 06-21-2009, 06:45 AM **#57**

But useful for programmers

1 - 1 Tongue

06-21-2009, 06:49 AM **#58**

(06-21-2009, 06:45 AM)nosound97 Wrote: But useful for programmers

1 - 1

Right. And MusicMod is useful to people who want to try it. Tongue

**KHRZ** · 06-21-2009, 06:58 AM **#59**

Heh just tested Zelda TP, finally some sound! Even though it sounds horrible, it's a little better than no sound if you set the volume low I guess. Can't wait to see it fixed correctly Smile

**Xtreme2damax** · (This post was last modified: 06-21-2009, 08:16 AM by Xtreme2damax.)

(06-21-2009, 06:36 AM)gcp111 Wrote:
(06-21-2009, 04:37 AM)Xtreme2damax Wrote: It also adds unnecessary bloat to the repository, wasting space so everyone has to download that much more from the repository to compile.

Quit whining. DSPSpy/DSPTool is also useless to most people, but it's still in the trunk.

I am not whining and it isn't just my opinion or view on Dolphin, go talk to other reputable developers such as mudlord, Omegadox, Dax and some other developers about their stance on Dolphin, hacks, and the music modification. They have all pretty much said the same thing, and they are entitled to say something.

I have no reason to whine or complain, when I can just play these games on my Wii. As far as I am concerned I am patient enough to wait for sound in these games, am I not allowed to offer my feedback or opinion on the matter?

I was pretty much restating what they said since I am in agreement with it. DSPSpy and DSPTool are in the trunk because they are useful to developers in reverse engineering the DSP hardware and improving DSP emulation where as music mod is just a hackish workaround which doesn't even work properly.

Dolphin's code base has become a mess with all these hacks, time is wasted on implementing hacks when the main focus should be on proper emulation of the hardware.

The TLB hack is understandable since proper emulation of TLB would have a dramatic performance impact, even the music modification was understandable up until a point. But I have to question things when I see several hacks for graphics being implemented, rather than focusing on proper emulation of the graphics hardware.

There is really no longer a need to include the music modification since there is actual progress being made on DSP emulation, instead the main focus should be prioritized on DSP emulation in order to get sound to work properly in Zelda/Mario games.

At the very least the music mod along with the other hacks should be moved to a separate branch or repository and kept out of the main trunk, even nakee pretty much stated the same:

http://code.google.com/p/dolphin-emu/source/detail?r=3505

nakee Wrote:can you please put it somewhere else and not in trunk?
like /musicmod?

I obviously expect someone to reply with the typical, Dolphin is open source so why don't you fix it? However the fact or reality is that not many of us have the knowledge to do so, but we should still be allowed to state our opinion without being crucified for it.