A serious control bug

[mangolo]

Hello.

I may not be an experienced coder or anything, but I recently found a serious bug with controls (no matter if it is gamepad or keyboard, njoy or x360 plugin) in the newer versions. I tried it with versions 4457 and above, all they present the same bug (even though by testing with version 4089 I got no problems); I'll try to put it in words, even though it is a little hard.

For example, you keep pressing any button, even though you do not release it, dolphin keeps "unpressing" the button.
Just take a look at this if you didn't understand: (I'll take Mario Kart as an example)


In the version 4089, the kart's acceleration was like this:
________________________________________
a constant value

In the newer versions, including several different builds from different builders, the kart's acceleratio is like this:
__ __ _ ____ _ _ ____ _____ __ ____ ___


I hope I made myself clear enough. Anyway, this may not look a serious bug, but when playing games such as Mario Superstar Baseball, where you have to charge your swings, it gets a pain in the ass.

You can even try to reproduce that bug, very easily, in Mario Kart. Just press left or right, you'll see your tire going and coming, like if you where tapping rapidly.

Sorry for making such a long post, but I figured out ppl should know about that. Also, if you guys solve that, I give you a hug

Joking

Thanks guys

EDIT: I also realized that by turning off the "Idle Skipping option" things goes as they should be. Could this have any relation with the bug?

[dstruct2k]

Skipped frames are most likely not being given controller input, so anytime a frame is skipped, the button is "released" for a frame or 2. Not sure, but if turning off Idle Skipping cures it, that would be my guess.

[mangolo]

Yes, that's my guess too. But by turning it off it gets unhappily slow

[dstruct2k]

What probably happened is that this "bug" has been around the entire time, you're just noticing it more now since build 4089 because 4089 slowed something down in the game and it's using the frame skipping a lot more now. You might want to consider using an older build to play this game for now until this issue is resolved.

The other possibility is that frameskipping code was changed in 4089 which introduced this bug. Either way... Older builds wouldn't have the problem.

[mangolo]

Still, I need someone to fix this problemo, since the new builds are way fasta. The people who compile the builds should pay attention to this, it's quite annoying.

I already said that, but I thought it was worth remembering that, after turning Idle-Skipping off, the problem goes away; The way it is now is impossible to emulate gamecube games accordingly to dolphin newbuilds' improved performance

[dyoo]

What if the controls are shared? Like both right and left keys have same button for example.

[mangolo]

Actually it didn't make any difference

[Legend80]

I noticed when using the left stick to duck in NSMB, that Mario immediately unducks. I have to let go and do it again but same thing happens. Have to use the d-pad to duck...and the 360 controller's d-pad sucks! Is this what you guys are talking about?

[mangolo]

Yeah, it's basically that. The button's action keeps going and coming, even though you didn't let it go