1000revisions old FIFO crash -Fix-

[Warrio_r]

can someone post setp by step how to apply and make the patch work ? if possible with images.

I have download the 5643M...but the game still freezes (SM sunshine) but maybe i made something wrong.

please help, thanks

Forget i found by my self but i´m going to post in game forum what we must do step by step

[DacoTaco]

(06-11-2010, 06:20 AM)IcemanSR Wrote: hm posting in svn issue?no didn't posted any issues in there.

*edit
now i see

Code:

http://code.google.com/p/dolphin-emu/issues/detail?id=2783

no that wasn't me ,either way although this patch does fix issues in some games it rise issues with some other games,so its not proper fix and i would not recommend it.


*Edit again

ok i am close to solution,just need to find correct break - interrupt they are main reason why fifo is doing jokes and ssx3 video problem.but in the same place is stability for other games and random hangups.

a i thought it was you, guess i was wrong tho

either way, it would be awesome to have a balance in the fifo again....eventho it hasn't been balanced in ages >_<;

[IcemanSR]

well, i am stuck at finding solution...
if i make fifo to work correct then ssx which uses update intervals hack stops updating gpu,result game is running but without gpu

[pit172]

Well, IcemanSR, your patch is really great for wii sports resort.
Thank you very,very much

Only one thing is not good, its the r5643 itself. The sound is bad, and the game sometimes not starting. I tested the regular version and its the same.

So i think the last thing to do is finding the perfect version for WSR and i say its 5333 - other suggestions?

[StripTheSoul]

@ IcemanSR: Wouldn't it be good to communicate (if not already happening) with Skidau? Especially because he's also working on FIFO stuff right now...maybe the two of you will be able to see around each other's roadblock

[magic]

can you test this: http://code.google.com/p/dolphin-emu/issues/detail?id=2579 ?

tales of graces doesn't work for me with and without these modifications on the most current svn build. i don't own ssx3 so unfortunately i can't test it.

in CommandProcess.cpp change:

Common::AtomicStore(fifo.bFF_BPEnable, tmpCtrl.BPEnable);

to:

if (tmpCtrl.BPInit && tmpCtrl.BPEnable){
Common::AtomicStore(fifo.bFF_BPEnable, 1);
}
else{
Common::AtomicStore(fifo.bFF_BPEnable, 0);
}

[IcemanSR]

to quote u:
''i have done some further experiments concerning possible race conditions by forcing the fifo loop to exit temporarily on any control register write. this didnt help, which brings me to the conclusion that the error probably lies within the interrupt scheduling from the video thread, which has not been executed when following breakpoints are hit.''

*EDIT

uh??when tales of grace stoped working on svn??

wii sport here works fine its ssx3 and tales of grace that bothers me.

[magic]

i don't know when it stopped working, but i also tested with the latest mamario build and it didnt work either.

i had a friend test ssx3 though and it doesnt work aswell with these changes, so the effect is basically the same like with your patch, just with fewer modifications.

[blackJade]

Actually, if you using lastest build to run Tales of Graces, it CAN START but stop in the cutscene.
So, you have to use spellforce's patch to get through it. This is an already known issue...
And I know fifo patch will crash tales of graces and I think IcemanSR will try to fix it.
So, If you need to play Tales of Graces. Just don't use this patch(for now) and add spellforce's build or patch to run it.

Ah...BTW, Tales of Graces need to change Wii into Japanese to run.
May be this will help you...

[IcemanSR]

..nvm found
i see his patch now.
hm it appears to be heavily modified dolphin core just to run that game.
i was under impression that tales of graces WORKS 100% on svn ,but at the end it turns out that so far only is ssx3 affected by my fifo changes.