1000revisions old FIFO crash -Fix-

[IcemanSR]

Problem first time occured in R4759

Code:

http://code.google.com/p/dolphin-emu/source/detail?r=4759&path=/trunk/Source/Core/VideoCommon/Src/Fifo.cpp#

since then many games then once worked stoped working or started crashing.

This will fix problems with FIFO issues.
it might as well fix a lot others unexplained random freezing problems!

Tested with following games.

Fight Night Round 2 TLB hack ON
Wii Sport Resort - no hangups
Metroid Prime
Mortal Kombat
Batallion wars 1,2
Timesplitters 2
Super Mario Sunshine. - no hangups.
list goes on.

it should also infect all others "broken" FIFO games

Be aware this does not affect game requirements for TLB hack
games like Fight night round still requires to have enabled TLB in order to start the game.BUT it fixes all crashes and errors coused by FIFO.





default svn picture : FIFO error:
error spams and crash dolphin.game is unplayable.



Patch made and tested for latest SVN 5643

download from attachment bellow.

here is custom build with this patch
64bit

Code:

http://rapidshare.com/files/397408743/5643Mx64.rar

32bit

Code:

http://rapidshare.com/files/397415424/5643Mx32.rar

added "specific svn revision" with this patch per request.

(06-13-2010, 10:43 PM)pit172 Wrote: I think 5333 is a good choice. It seems to be fast and there are no problems with sound...
Would you do that? I need x32 to be exactly

Thank you, again

ABANDONED PROJECT!
u can still use above to play mentioned games.for rest look at svn.

[RupeeClock]

If anyone would be willing to compile this for 32bit Windows, I'd be happy to test Super Mario Sunshine, and Wii Sports Resort.

[StripTheSoul]

wow, sounds good!
Skidau should have a look at this.
I'd be happy to mark some of the games in my "broken"-list as "fixed" for a change

[IcemanSR]

OK
EDIT
added both 64 and 32 bit builds to first post.

[RupeeClock]

(06-10-2010, 09:17 PM)IcemanSR Wrote: OK
EDIT
added both 64 and 32 bit builds to first post.

Wonderful, I'll get to playing some Mario Sunshine and report back.

Edit: I was able to play Mario Sunshine for a solid hour with no freezes what-so-ever, fantastic.
I'll test Wii Sports Resort later, my wiimote is recharging.

I was also experiencing freezes in Luigi's Mansion, i'll see if those are gone.

[RetroX]

battalion wars, timesplitters 2 working again
ssx 3 not working anymore (it didnt work before 47xx)

[IcemanSR]

@RupeeClock i am glad.
@RetroX ssx 3?which game is that? *edit i see now well i do not have that game,what are the issues ?

[RetroX]

black screen (intro)... fps: 0, vps: 60

[DacoTaco]

so basicly you have the same issue in ssx 3 that other games have with the current fifo?
joy >_>

[IcemanSR]

i tested big ammount of fifo games releated issues,i did not have ssx3 it might not be something special,i will contact few of my friends to see if anyone have ssx3.

do u get black screen only or it gives fifo error ?
when error start to show at immediate start of game or ?
when did u experienced problem first time if u can remember?

*edit
reason:
googled some ssx3 problems
from here

Code:

http://code.google.com/p/dolphin-emu/issues/detail?id=2350

i see problem occurred somewhere between 5059 and 5115,if information is correct.
it might not be fifo related,i will see what else i can find out.